Clean, test & refactor 64 to 32 bit conversion step. #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc-white
reviewed
Sep 6, 2024
marc-white
reviewed
Sep 6, 2024
marc-white
reviewed
Sep 6, 2024
marc-white
reviewed
Sep 6, 2024
marc-white
reviewed
Sep 6, 2024
marc-white
reviewed
Sep 6, 2024
marc-white
reviewed
Sep 6, 2024
blimlim
previously approved these changes
Sep 10, 2024
|
@marc-white did you want to do a final skim/review of the "end" product? |
|
Looks good to me. I just tried to resolve the last outstanding comment, but Github is being difficult... maybe the VSCode extension can save me... |
marc-white
approved these changes
Sep 11, 2024
I could close the convo off... |
|
Awesome, I think closing the open conversation thread off removed review approvals. @marc-white or @blimlim would either of you mind doing another approval to enable a merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #95.
This PR is mostly to extract & test 64 to 32 bit down-conversion from
cubewrite().I've added a few things:
datamember toDummyCube, so data grids can be attached to imitation cubes (it's simpler to reuse fixtures).I'll defer moving this step into
process()untilcubewrite()is deconstructed.Comments welcome :-)