perf(frontend) : Setup redux toolkit with persist #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ngha-Boris
requested changes
May 2, 2024
src/app.tsx
Outdated
Comment on lines
17
to
20
| <div> | ||
| <LoginButton /> | ||
| <LogoutButton /> | ||
| </div> |
There was a problem hiding this comment.
The LoginButton and LogoutButton are rendered outside of routes in app.tsx. This means they'll be visible on all pages.
Please @Arielpetit, consider conditionally rendering the buttons based on the isLoggedIn state.
|
Hey please @stephane-segning and @Ngha-Boris review this again |
Ngha-Boris
reviewed
May 6, 2024
.husky/pre-commit
Outdated
There was a problem hiding this comment.
Hello @Arielpetit what is this file for?
stephane-segning
requested changes
May 7, 2024
package.json
Outdated
| @@ -29,6 +32,8 @@ | |||
| "@eslint/eslintrc": "^3.0.2", | |||
| "@types/react": "^18.2.66", | |||
| "@types/react-dom": "^18.2.22", | |||
| "@reduxjs/toolkit": "^2.2.3", | |||
There was a problem hiding this comment.
This should be in dep, not dev dep
src/components/home-page.tsx
Outdated
There was a problem hiding this comment.
Cancel all these changes
stephane-segning
requested changes
May 7, 2024
valsuh45
reviewed
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review this PR @stephane-segning @ValantineSuh @Ngha-Boris