Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement QR Code generator for presenting DID to another wallet #13

Conversation

Awambeng
Copy link
Collaborator

@Awambeng Awambeng commented Jan 8, 2025

No description provided.

Copy link
Collaborator

@IngridPuppet IngridPuppet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like how your implementation is componentized. Just a few comments regarding UX...

src/App.tsx Outdated Show resolved Hide resolved
src/components/BottomNav.tsx Outdated Show resolved Hide resolved
src/components/qrcodegenerator/QRCodeDisplay.tsx Outdated Show resolved Hide resolved
src/components/qrcodegenerator/QRCodeGenerator.tsx Outdated Show resolved Hide resolved
@Awambeng Awambeng requested a review from IngridPuppet January 10, 2025 07:29
@Awambeng Awambeng merged commit 0634180 into main Jan 10, 2025
2 checks passed
@Awambeng Awambeng deleted the 12-app-ui-layer-generate-qr-code-to-present-a-wallet-address-to-another-wallet branch January 10, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App UI layer generate QR Code to present a wallet address to another wallet
2 participants