-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
11 tk 018 create rest endpoint to receive otp at obs #40
Merged
Koufan-De-King
merged 7 commits into
main
from
11--tk-018-create-rest-endpoint-to-receive-otp-at-obs
Oct 28, 2024
Merged
11 tk 018 create rest endpoint to receive otp at obs #40
Koufan-De-King
merged 7 commits into
main
from
11--tk-018-create-rest-endpoint-to-receive-otp-at-obs
Oct 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koufan-De-King
requested review from
francis-pouatcha,
Elwizzy12,
Arielpetit,
NkwaTambe,
nancymuyeh and
yvanhenang
October 24, 2024 17:36
Arielpetit
requested changes
Oct 25, 2024
obs/obs-rest-api/src/main/java/com/adorsys/webank/obs/resource/OtpRequest.java
Outdated
Show resolved
Hide resolved
online-banking-app/src/test/java/com/adorsys/webank/OnlineBankingApplicationTests.java
Outdated
Show resolved
Hide resolved
francis-pouatcha
requested changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
Elwizzy12
previously approved these changes
Oct 25, 2024
NkwaTambe
previously approved these changes
Oct 25, 2024
francis-pouatcha
previously approved these changes
Oct 28, 2024
Arielpetit
previously approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
yvanhenang
previously approved these changes
Oct 28, 2024
Koufan-De-King
dismissed stale reviews from yvanhenang, Arielpetit, francis-pouatcha, NkwaTambe, and Elwizzy12
via
October 28, 2024 07:09
d315997
nancymuyeh
approved these changes
Oct 28, 2024
NkwaTambe
approved these changes
Oct 28, 2024
Koufan-De-King
deleted the
11--tk-018-create-rest-endpoint-to-receive-otp-at-obs
branch
October 28, 2024 07:12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.