Jmafoster1/237 consistent footer behaviour

[jmafoster1]

Closes https://github.com/GateNLP/we-verify-app-assistant/issues/237.

• All assistant text result footer icons now have a tooltip on hover (without changing the source of TextCopy and Translate).
• ExpandMinimise now has pointer cursor to match the other two. It doesn't seem to be used elsewhere so this shouldn't break anything else.

None of the icons seems to visibly "highlight" on hover for me before or after the change.

[rosannamilner]

Interesting. I can see the hover text on all three, however I can visibly see the highlight on only the TextCopy and Translate. ExpandMinimise does have a Tooltip which should create the highlight?

[jmafoster1]

That's very strange. Perhaps my monitor is just old, but I only see the tooltip text when I hover. I added a tooltip to ExpandMinimise, so the behaviour should be consistent now.

[rosannamilner]

On your image above I can see the highlight so that's working, and same for TextCopy.

It's clearer on TextCopy (perhaps because the icon is smaller).

But it still isn't there on ExpandMinimise even with the Tooltip which is strange.

[jmafoster1]

I still could not see it on your image, but I can if I bring the contrast right up! Maybe I need to adjust the settings on my monitor, or my eyes. I'll see if I can work out where the highlighting code is and get that sorted.

[rosannamilner]

I was wondering if it was my eyes not seeing it for ExpandMinimise haha - maybe if it's hard for us, then perhaps the consistency isn't too important if it turns out to be challenging.

[jmafoster1]

@rosannamilner, looking at this on my office machine, I can just about see it. I ended up removing the hover from TextCopy and Translate since the icons overflow the highlighted area, making it look very strange to me. The cause of this was that those two tools are Button elements, which change colour by default on hover. ExpandMinimise is just an icon, so has no such behaviour.

EDIT: I re-requested a review from @rosannamilner since I can still only barely see it!

[rosannamilner]

Now I can't see any highlights on hover for all three - but that is consistent! I just checked the youtube comments on the Video Analysis tool which uses TextCopy and Translate - neither of these have the grey circle hover so perhaps it's best to leave it as they both don't have it.

They are all consistent now with the hover text appearing.