Skip to content

Commit

Permalink
Turborepo script adjustments (MystenLabs#15088)
Browse files Browse the repository at this point in the history
## Description 

Addressing MystenLabs#14967.

By @Jordan-Mysten's request, helping out with commands for local
development.

## Test Plan 

How did you test the new or updated feature?

See MystenLabs#14967 notes.

---
If your changes are not user-facing and not a breaking change, you can
skip the following section. Otherwise, please indicate what changed, and
then add to the Release Notes section as highlighted during the release
process.

### Type of Change (Check all that apply)

- [ ] protocol change
- [ ] user-visible impact
- [ ] breaking change for a client SDKs
- [ ] breaking change for FNs (FN binary must upgrade)
- [ ] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration

---------

Co-authored-by: Jordan Gensler <[email protected]>
  • Loading branch information
anthonyshew and Jordan-Mysten authored Nov 29, 2023
1 parent f5c37a1 commit 6344107
Show file tree
Hide file tree
Showing 6 changed files with 66 additions and 68 deletions.
2 changes: 1 addition & 1 deletion apps/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"eslint:fix": "pnpm run eslint:check --fix",
"lint": "pnpm run eslint:check && pnpm run prettier:check",
"lint:fix": "pnpm run eslint:fix && pnpm run prettier:fix",
"test": "turbo --filter @mysten/core^... build && vitest run",
"test": "vitest run",
"test:watch": "vitest"
},
"dependencies": {
Expand Down
2 changes: 0 additions & 2 deletions apps/explorer/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
"private": true,
"scripts": {
"dev": "vite --port 3000",
"dev-deps": "turbo run dev --filter sui-explorer^... --concurrency 100",
"dev-local": "vite --port 3000",
"test": "pnpm test:unit",
"test:unit": "vitest run",
"typecheck": "tsc -b",
Expand Down
123 changes: 62 additions & 61 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,63 +1,64 @@
{
"name": "sui-monorepo",
"private": true,
"license": "Apache-2.0",
"scripts": {
"turbo": "turbo",
"icons": "pnpm --filter ./apps/icons",
"explorer": "turbo --filter sui-explorer",
"wallet": "turbo --filter ./apps/wallet",
"sdk": "turbo --filter ./sdk/typescript",
"bcs": "turbo --filter ./sdk/bcs",
"changeset-version": "pnpm changeset version && pnpm --filter @mysten/sui.js codegen:version",
"prettier:check": "prettier -c --ignore-unknown .",
"prettier:fix": "prettier -w --ignore-unknown .",
"prettier:fix:watch": "onchange '**' -i -f add -f change -j 5 -- prettier -w --ignore-unknown {{file}}",
"eslint:check": "eslint --max-warnings=0 .",
"eslint:fix": "pnpm run eslint:check --fix",
"lint": "pnpm run eslint:check && pnpm run prettier:check",
"lint:fix": "pnpm run eslint:fix && pnpm run prettier:fix"
},
"pnpm": {
"overrides": {
"node-notifier": "10.0.0",
"async": "3.2.2",
"nth-check": "2.0.1",
"yaml@<2.2.2": ">=2.2.2",
"semver@<7.5.2": ">=7.5.2",
"postcss@<8.4.31": ">=8.4.31"
}
},
"engines": {
"pnpm": ">=8.6.5"
},
"manypkg": {
"ignoredRules": [
"INTERNAL_MISMATCH",
"ROOT_HAS_DEV_DEPENDENCIES"
]
},
"devDependencies": {
"@changesets/cli": "^2.26.2",
"@ianvs/prettier-plugin-sort-imports": "^4.1.0",
"@manypkg/cli": "^0.21.0",
"@tanstack/eslint-plugin-query": "^5.0.0",
"@typescript-eslint/eslint-plugin": "^6.1.0",
"@typescript-eslint/parser": "^6.1.0",
"concurrently": "^8.2.0",
"eslint": "^8.45.0",
"eslint-config-prettier": "^8.8.0",
"eslint-config-react-app": "^7.0.1",
"eslint-import-resolver-typescript": "^3.5.5",
"eslint-plugin-header": "^3.1.1",
"eslint-plugin-import": "^2.27.5",
"eslint-plugin-prettier": "^5.0.0",
"eslint-plugin-require-extensions": "^0.1.3",
"eslint-plugin-tsdoc": "^0.2.17",
"eslint-plugin-unused-imports": "^3.0.0",
"prettier": "^3.0.0",
"prettier-plugin-tailwindcss": "^0.4.1",
"turbo": "^1.10.8",
"typescript": "^5.1.6"
}
"name": "sui-monorepo",
"private": true,
"license": "Apache-2.0",
"scripts": {
"test": "turbo run test",
"test:dev": "turbo run test -- --run",
"icons": "pnpm --filter ./apps/icons",
"explorer": "turbo --filter sui-explorer",
"wallet": "turbo --filter ./apps/wallet",
"sdk": "turbo --filter ./sdk/typescript",
"bcs": "turbo --filter ./sdk/bcs",
"changeset-version": "pnpm changeset version && pnpm --filter @mysten/sui.js codegen:version",
"prettier:check": "prettier -c --ignore-unknown .",
"prettier:fix": "prettier -w --ignore-unknown .",
"prettier:fix:watch": "onchange '**' -i -f add -f change -j 5 -- prettier -w --ignore-unknown {{file}}",
"eslint:check": "eslint --max-warnings=0 .",
"eslint:fix": "pnpm run eslint:check --fix",
"lint": "pnpm run eslint:check && pnpm run prettier:check",
"lint:fix": "pnpm run eslint:fix && pnpm run prettier:fix"
},
"pnpm": {
"overrides": {
"node-notifier": "10.0.0",
"async": "3.2.2",
"nth-check": "2.0.1",
"yaml@<2.2.2": ">=2.2.2",
"semver@<7.5.2": ">=7.5.2",
"postcss@<8.4.31": ">=8.4.31"
}
},
"engines": {
"pnpm": ">=8.6.5"
},
"manypkg": {
"ignoredRules": [
"INTERNAL_MISMATCH",
"ROOT_HAS_DEV_DEPENDENCIES"
]
},
"devDependencies": {
"@changesets/cli": "^2.26.2",
"@ianvs/prettier-plugin-sort-imports": "^4.1.0",
"@manypkg/cli": "^0.21.0",
"@tanstack/eslint-plugin-query": "^5.0.0",
"@typescript-eslint/eslint-plugin": "^6.1.0",
"@typescript-eslint/parser": "^6.1.0",
"concurrently": "^8.2.0",
"eslint": "^8.45.0",
"eslint-config-prettier": "^8.8.0",
"eslint-config-react-app": "^7.0.1",
"eslint-import-resolver-typescript": "^3.5.5",
"eslint-plugin-header": "^3.1.1",
"eslint-plugin-import": "^2.27.5",
"eslint-plugin-prettier": "^5.0.0",
"eslint-plugin-require-extensions": "^0.1.3",
"eslint-plugin-tsdoc": "^0.2.17",
"eslint-plugin-unused-imports": "^3.0.0",
"prettier": "^3.0.0",
"prettier-plugin-tailwindcss": "^0.4.1",
"turbo": "^1.10.8",
"typescript": "^5.1.6"
}
}
2 changes: 0 additions & 2 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions pnpm-workspace.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,4 @@ packages:
- '!sdk/typescript/bcs'
- '!sdk/typescript/zklogin'
- '!sdk/enoki/react'
- '!sdk/move-binary-format-wasm/pkg'
4 changes: 2 additions & 2 deletions turbo.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"pipeline": {
"lint": {},
"test": {
"dependsOn": ["^build"],
"dependsOn": ["^build", "build"],
"outputs": ["coverage/**"]
},
"dev": {
Expand All @@ -13,7 +13,7 @@
},
"build": {
"dependsOn": ["^build"],
"outputs": ["build/**", "dist/**", "storybook-static/**", ".next/**", "!.next/cache/**"]
"outputs": ["build/**", "dist/**", "storybook-static/**", ".next/**", "!.next/cache/**", "pkg/**"]
}
},
"globalEnv": ["VERCEL_ENV", "VITE_NETWORK", "VITE_VERCEL_ANALYTICS_ID", "VITE_SENTRY_SAMPLE_RATE"]
Expand Down

0 comments on commit 6344107

Please sign in to comment.