[move] Remove read-write-set analysis (MystenLabs#14469)

## Description 

Remove read-write-set analysis as it's no longer needed.

## Test Plan 

Make sure existing tests still pass

---
If your changes are not user-facing and not a breaking change, you can
skip the following section. Otherwise, please indicate what changed, and
then add to the Release Notes section as highlighted during the release
process.

### Type of Change (Check all that apply)

- [ ] protocol change
- [ ] user-visible impact
- [ ] breaking change for a client SDKs
- [ ] breaking change for FNs (FN binary must upgrade)
- [ ] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration

### Release notes

Cargo.toml

@@ -59,9 +59,7 @@ exclude = [
     "external-crates/move/tools/move-package",
     "external-crates/move/tools/move-resource-viewer",
     "external-crates/move/tools/move-unit-test",
-    "external-crates/move/tools/read-write-set",
-    "external-crates/move/tools/read-write-set/dynamic",
-    "external-crates/move/tools/read-write-set/types",
+    "external-crates/move/tools/move-read-write-set-types",
     "sdk/move-binary-format-wasm",
 ]
 

crates/workspace-hack/Cargo.toml

@@ -430,7 +430,7 @@ move-model = { path = "../../external-crates/move/move-model", default-features
 move-package = { path = "../../external-crates/move/tools/move-package", default-features = false }
 move-prover = { path = "../../external-crates/move/move-prover", default-features = false }
 move-prover-boogie-backend = { path = "../../external-crates/move/move-prover/boogie-backend", default-features = false }
-move-read-write-set-types = { path = "../../external-crates/move/tools/read-write-set/types", default-features = false }
+move-read-write-set-types = { path = "../../external-crates/move/tools/move-read-write-set-types", default-features = false }
 move-resource-viewer = { path = "../../external-crates/move/tools/move-resource-viewer", default-features = false }
 move-stackless-bytecode = { path = "../../external-crates/move/move-prover/bytecode", default-features = false }
 move-stackless-bytecode-interpreter = { path = "../../external-crates/move/move-prover/interpreter", default-features = false }
@@ -564,8 +564,6 @@ rand_xoshiro = { version = "0.6", default-features = false }
 rayon = { version = "1", default-features = false }
 rayon-core = { version = "1", default-features = false }
 rcgen = { version = "0.9" }
-read-write-set = { path = "../../external-crates/move/tools/read-write-set", default-features = false }
-read-write-set-dynamic = { path = "../../external-crates/move/tools/read-write-set/dynamic", default-features = false }
 ref-cast = { version = "1", default-features = false }
 regex = { version = "1" }
 regex-automata = { version = "0.1" }
@@ -1248,7 +1246,7 @@ move-package = { path = "../../external-crates/move/tools/move-package", default
 move-proc-macros = { path = "../../external-crates/move/testing-infra/move-proc-macros", default-features = false }
 move-prover = { path = "../../external-crates/move/move-prover", default-features = false }
 move-prover-boogie-backend = { path = "../../external-crates/move/move-prover/boogie-backend", default-features = false }
-move-read-write-set-types = { path = "../../external-crates/move/tools/read-write-set/types", default-features = false }
+move-read-write-set-types = { path = "../../external-crates/move/tools/move-read-write-set-types", default-features = false }
 move-resource-viewer = { path = "../../external-crates/move/tools/move-resource-viewer", default-features = false }
 move-stackless-bytecode = { path = "../../external-crates/move/move-prover/bytecode", default-features = false }
 move-stackless-bytecode-interpreter = { path = "../../external-crates/move/move-prover/interpreter", default-features = false }
@@ -1413,8 +1411,6 @@ rand_xoshiro = { version = "0.6", default-features = false }
 rayon = { version = "1", default-features = false }
 rayon-core = { version = "1", default-features = false }
 rcgen = { version = "0.9" }
-read-write-set = { path = "../../external-crates/move/tools/read-write-set", default-features = false }
-read-write-set-dynamic = { path = "../../external-crates/move/tools/read-write-set/dynamic", default-features = false }
 readonly = { version = "0.2", default-features = false }
 ref-cast = { version = "1", default-features = false }
 ref-cast-impl = { version = "1", default-features = false }

external-crates/move/Cargo.toml

@@ -61,9 +61,7 @@ members = [
     "tools/move-package",
     "tools/move-resource-viewer",
     "tools/move-unit-test",
-    "tools/read-write-set",
-    "tools/read-write-set/dynamic",
-    "tools/read-write-set/types",
+    "tools/move-read-write-set-types",
 ]
 
 # Dependencies that should be kept in sync through the whole workspace
@@ -79,7 +77,6 @@ bcs = "0.1.4"
 bitvec = "0.19.4"
 byteorder = "1.4.3"
 prover_bytecode = { path = "move-prover/bytecode", package="move-stackless-bytecode" }
-read-write-set-dynamic = { path = "tools/read-write-set/dynamic" }
 bytes = "1.0.1"
 clap = { version = "4", features = ["derive"] }
 module-generation = { path = "testing-infra/module-generation" }
@@ -198,8 +195,7 @@ async-trait = "0.1.42"
 pretty = "0.10.0"
 futures = "0.3.12"
 paste = "1.0.5"
-move-read-write-set-types = { path = "tools/read-write-set/types" }
-read-write-set = { path = "tools/read-write-set" }
+move-read-write-set-types = { path = "tools/move-read-write-set-types" }
 move-stackless-bytecode-interpreter = { path = "move-prover/interpreter" }
 tera = "1.16.0"
 tokio = { version = "1.18.2", features = ["full"] }

external-crates/move/tools/README.md

@@ -43,9 +43,8 @@ multiple packages, and multiple runs over a package. This functionality is
 important if you have a large functional test suite such as Diem's and want
 to gather coverage information across all of them.
 
-The `move-resource-viewer`, and `read-write-set` similarly are library
-crates that are used by and exposed by the Move CLI, but not through the
-`package` subcommand.
+The `move-resource-viewer` is a library crate that is used by and exposed by
+the Move CLI, but not through the `package` subcommand.
 
 The `move-bytecode-utils` crates holds general
 utilities for working with Move bytecode, e.g., computing the dependency

external-crates/move/tools/move-cli/Cargo.toml

@@ -36,7 +36,7 @@ move-vm-types.workspace = true
 move-vm-runtime.workspace = true
 move-vm-profiler.workspace = true
 move-vm-test-utils.workspace = true
-read-write-set.workspace = true
+move-read-write-set-types.workspace = true
 move-resource-viewer.workspace = true
 move-binary-format.workspace = true
 move-package.workspace = true