Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vasp scf nbands #229

Merged
merged 1 commit into from
Dec 20, 2023
Merged

vasp scf nbands #229

merged 1 commit into from
Dec 20, 2023

Conversation

FCMeng
Copy link
Collaborator

@FCMeng FCMeng commented Dec 16, 2023

fixing the nbands in vasp scf calcualtions

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (81a0dab) 77.21% compared to head (77fc381) 77.21%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #229   +/-   ##
=======================================
  Coverage   77.21%   77.21%           
=======================================
  Files          13       13           
  Lines        1040     1040           
=======================================
  Hits          803      803           
  Misses        237      237           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewcarbone
Copy link
Contributor

@FCMeng silly question: how does VASP automatically assign the number of bands? I actually didn't even realize VASP did this 😁 I just never tried to not provide the number of bands in the INCAR.

@FCMeng
Copy link
Collaborator Author

FCMeng commented Dec 17, 2023

@matthewcarbone I remember there is a default setting for NBANDS in VASP. If it is insulator, it would be the (number of valence bands from psp + 4). If it is metal, it would be (number of valence bands from psp)*1.04. I might be wrong with the absolute numbers here.

@matthewcarbone matthewcarbone merged commit d17ba7c into master Dec 20, 2023
14 checks passed
@matthewcarbone matthewcarbone deleted the vasp_scf branch December 20, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants