Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiling with Clang 18 and a few warnings #1290

Merged
merged 3 commits into from
Jul 6, 2024

Conversation

jmcarcell
Copy link
Member

@jmcarcell jmcarcell commented Jul 6, 2024

The header is needed to be able to find ::open and ::close. For the warnings I commented out one case instead of removing it because the place where it's used is also commented out (here, so it would be easy to reenable in case someone wanted to...).

BEGINRELEASENOTES

  • Add the missing header unistd.h in a file to find ::open and ::close
  • Fix a few warnings about unused variables or shadowing
  • Add .cache and compile_commands.json to .gitignore

ENDRELEASENOTES

Copy link

github-actions bot commented Jul 6, 2024

Test Results

   14 files     14 suites   6h 39m 28s ⏱️
  365 tests   365 ✅ 0 💤 0 ❌
2 510 runs  2 510 ✅ 0 💤 0 ❌

Results for commit e3264a5.

@andresailer andresailer merged commit fe64884 into AIDASoft:master Jul 6, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants