-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SurfaceManager: lazily construct surface maps on demand #1304
base: master
Are you sure you want to change the base?
Conversation
Test Results 14 files 14 suites 7h 8m 12s ⏱️ For more details on these failures, see this check. Results for commit 3f99f2a. ♻️ This comment has been updated with latest results. |
e3c72fb
to
3f99f2a
Compare
I tried to make the commits a bit more readable. I can remove the white space removing commit if you insist. Overall the changes seem to work, but I don't know if they are useful for someone. The initial motivation was to speed-up loading of the CLD detector. However, as it turns out, there we also load in the next step a plugin that accesses all surfaces anyway so no performance gain can be observed 🤷 |
At least this PR told me that something in dev3 is breaking DD4hep :/ |
|
BEGINRELEASENOTES
ENDRELEASENOTES
@jmcarcell FYI :)