Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SurfaceManager: lazily construct surface maps on demand #1304

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Zehvogel
Copy link
Contributor

@Zehvogel Zehvogel commented Jul 31, 2024

BEGINRELEASENOTES

  • Changed SurfaceManager to only construct surfaces and their maps on demand.

ENDRELEASENOTES

@jmcarcell FYI :)

Copy link

github-actions bot commented Jul 31, 2024

Test Results

   14 files     14 suites   7h 8m 12s ⏱️
  365 tests   352 ✅ 0 💤 13 ❌
2 510 runs  2 473 ✅ 0 💤 37 ❌

For more details on these failures, see this check.

Results for commit 3f99f2a.

♻️ This comment has been updated with latest results.

@Zehvogel
Copy link
Contributor Author

Zehvogel commented Aug 2, 2024

I tried to make the commits a bit more readable. I can remove the white space removing commit if you insist.

Overall the changes seem to work, but I don't know if they are useful for someone. The initial motivation was to speed-up loading of the CLD detector. However, as it turns out, there we also load in the next step a plugin that accesses all surfaces anyway so no performance gain can be observed 🤷

@andresailer
Copy link
Member

andresailer commented Aug 2, 2024

At least this PR told me that something in dev3 is breaking DD4hep :/

@andresailer
Copy link
Member

At least this PR told me that something in dev3 is breaking DD4hep :/

root-project/root#16167

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants