Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3 update view page #13

Merged
merged 6 commits into from
Aug 29, 2024
Merged

3 update view page #13

merged 6 commits into from
Aug 29, 2024

Conversation

nbodony
Copy link
Collaborator

@nbodony nbodony commented Jul 31, 2024 •
edited
Loading

  • Carousel now takes up the left 75% of the page
  • Download, license, and croissant buttons, keywords, download size, created date, and contact now take up the right 25%
  • Description and funding are now below the carousel and take up 100% of the width of the page
  • All buttons have relevant icons and tooltips
  • Carousel now works properly with multiple images
  • Carousel now keeps the height and width ratio of the images intact when the window changes in dimensions
  • Adjusted keywords so that they display in a vertical list
  • Download page now has 'safe' tag so the html list in the description works

image
image

image
image

Button tooltips:
image
image
image

Carousel image margins adjusting on skinny window:
image

nbodony added 4 commits July 30, 2024 16:38
@nbodony
View page changes
a31c844 
Fixed carousel indicators
Added safe tag to download description
Added usable keyword lists to datasets.json
Added icon buttons for download, license, croissant
Moved carousel to left 75% of screen, next to icon buttons
Added keywords below contact info
Moved rest of contents below carousel
@nbodony
Stop carousel images from being stretched
d7bec32 
In a thinner window, carousel images will now have a top and bottom border.
The images will maintain their original aspect ratio and the carousel itself will not change in height
@nbodony
Better looking keyword list
69ed319 
All keywords are followed by a comma except for the last in the set
@nbodony
Remove test stuff
09067e8 
Removed test images and keywords
Removed extra download button
Removed extra download size text
@nbodony nbodony linked an issue Jul 31, 2024 that may be closed by this pull request
update view page #3
Closed
@nbodony nbodony marked this pull request as ready for review July 31, 2024 20:36
@nbodony nbodony requested a review from robkooper July 31, 2024 20:36
@robkooper robkooper linked an issue Aug 5, 2024 that may be closed by this pull request
add keywords #4
Closed
@nbodony
Small changes
1b05bcf 
Download button shows "Download" tooltip
Contact has clickable email link
Moved created date to right column
Made keywords a vertical list
Added download size below keywords
robkooper
robkooper requested changes Aug 17, 2024
View reviewed changes
@nbodony
hardcoded contact info + variable case
27c0f42 
made keywords variable all lowercase
removed hardcoded html in contact info
@robkooper robkooper merged commit f92d2dd into main Aug 29, 2024
1 check passed
@robkooper robkooper deleted the 3-update-view-page branch August 29, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robkooper robkooper robkooper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add keywords update view page
2 participants
@nbodony @robkooper