Skip to content

Commit

Permalink
Fix ExpData equality operator for Python (#2194)
Browse files Browse the repository at this point in the history
Wasn't automatically handled by swig for unclear reasons. Works now. Fixes #2190.
  • Loading branch information
dweindl authored Nov 15, 2023
1 parent eccdc1f commit 187362a
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 0 deletions.
9 changes: 9 additions & 0 deletions python/tests/test_swig_interface.py
Original file line number Diff line number Diff line change
Expand Up @@ -442,3 +442,12 @@ def test_edata_repr():
assert expected_str in repr(e)
# avoid double delete!!
edata_ptr.release()


def test_edata_equality_operator():
e1 = amici.ExpData(1, 2, 3, [3])
e2 = amici.ExpData(1, 2, 3, [3])
assert e1 == e2
# check that comparison with other types works
# this is not implemented by swig by default
assert e1 != 1
3 changes: 3 additions & 0 deletions swig/edata.i
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,9 @@ def _edata_repr(self: "ExpData"):
%pythoncode %{
def __repr__(self):
return _edata_repr(self)

def __eq__(self, other):
return other.__class__ == self.__class__ and __eq__(self, other)
%}
};
%extend std::unique_ptr<amici::ExpData> {
Expand Down

0 comments on commit 187362a

Please sign in to comment.