Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sbml2amici / DEExporter compiler argument doesn't do anything #2140

Closed
dweindl opened this issue Jul 6, 2023 · 0 comments · Fixed by #2168
Closed

sbml2amici / DEExporter compiler argument doesn't do anything #2140

dweindl opened this issue Jul 6, 2023 · 0 comments · Fixed by #2168
Assignees
@dweindl
Labels
bug

Comments

@dweindl
Copy link
Member

dweindl commented Jul 6, 2023

Since switching to CMake-based extension builds, the compiler argument to sbml2amici / DEExporter doesn't do anything anymore.

This should be adapted to work with CMake or be removed.
@dweindl dweindl added the bug label Jul 6, 2023
@dweindl dweindl self-assigned this Aug 30, 2023
dweindl added a commit that referenced this issue Aug 30, 2023
@dweindl
Fix unused pysb2amici / sbml2amici / DEExporter compiler argument
03101e1 
This was ignored since switching to CMake-based builds.
Now it works again. The value of `compiler` is forwarded
to the `CXX` environment variable when CMake is invoked.

Fixes #2140
dweindl added a commit that referenced this issue Aug 30, 2023
@dweindl
Fix unused pysb2amici / sbml2amici / DEExporter compiler argument
cdc7786 
This was ignored since switching to CMake-based builds.
Now it works again. The value of `compiler` is forwarded
to the `CXX` environment variable when CMake is invoked.

Fixes #2140
@dweindl dweindl mentioned this issue Aug 30, 2023
Merged
dweindl added a commit that referenced this issue Aug 31, 2023
@dweindl
Fix unused pysb2amici / sbml2amici / DEExporter compiler argument (#…
09427ad 
…2168)

This was ignored since switching to CMake-based builds.
Now it works again. The value of `compiler` is forwarded
to the `CXX` environment variable when CMake is invoked.

Fixes #2140
@dweindl dweindl linked a pull request Nov 20, 2023 that will close this issue
Fix unused pysb2amici / sbml2amici / DEExporter compiler argument #2168
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dweindl dweindl

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix unused pysb2amici / sbml2amici / DEExporter compiler argument AMICI-dev/AMICI
1 participant
@dweindl