Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unused pysb2amici / sbml2amici / DEExporter compiler argument #2168

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Fix unused pysb2amici / sbml2amici / DEExporter compiler argument #2168

merged 1 commit into from
Aug 31, 2023

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Aug 30, 2023

This was ignored since switching to CMake-based builds. Now it works again. The value of compiler is forwarded to the CXX environment variable when CMake is invoked.

Fixes #2140

@dweindl
Fix unused pysb2amici / sbml2amici / DEExporter compiler argument
cdc7786 
This was ignored since switching to CMake-based builds.
Now it works again. The value of `compiler` is forwarded
to the `CXX` environment variable when CMake is invoked.

Fixes #2140
@dweindl dweindl requested a review from a team as a code owner August 30, 2023 10:18
@codecov
Copy link

codecov bot commented Aug 30, 2023 •
edited
Loading

Codecov Report

Merging #2168 (cdc7786) into develop (7d161a6) will increase coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2168      +/-   ##
===========================================
+ Coverage    76.67%   76.68%   +0.01%     
===========================================
  Files           82       82              
  Lines        14939    14940       +1     
===========================================
+ Hits         11454    11457       +3     
+ Misses        3485     3483       -2
Flag Coverage Δ
cpp 73.58% <ø> (+0.02%) ⬆️
petab 54.24% <50.00%> (+<0.01%) ⬆️
python 77.29% <50.00%> (+<0.01%) ⬆️
sbmlsuite ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage
python/sdist/amici/pysb_import.py ø
python/sdist/amici/sbml_import.py ø
python/sdist/amici/de_export.py 50.00%

@dweindl dweindl merged commit 09427ad into develop Aug 31, 2023
22 of 23 checks passed
@dweindl dweindl deleted the fix_2140_compiler branch August 31, 2023 08:21
dweindl added a commit that referenced this pull request Sep 20, 2023
@dweindl
Fix unused pysb2amici / sbml2amici / DEExporter compiler argument (#…
890b993 
…2168)

This was ignored since switching to CMake-based builds.
Now it works again. The value of `compiler` is forwarded
to the `CXX` environment variable when CMake is invoked.

Fixes #2140
@dweindl dweindl linked an issue Nov 20, 2023 that may be closed by this pull request
sbml2amici / DEExporter compiler argument doesn't do anything #2140
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FFroehlich FFroehlich FFroehlich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sbml2amici / DEExporter compiler argument doesn't do anything
2 participants
@dweindl @FFroehlich