Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gradient checks for SBML test suite #2093

Draft
wants to merge 26 commits into
base: develop
Choose a base branch
from

Conversation

dilpath
Copy link
Member

@dilpath dilpath commented May 16, 2023

No description provided.

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.49%. Comparing base (b4ab8a2) to head (179be29).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2093      +/-   ##
===========================================
- Coverage    77.88%   76.49%   -1.40%     
===========================================
  Files          322      317       -5     
  Lines        20678    20523     -155     
  Branches      1440     1438       -2     
===========================================
- Hits         16105    15699     -406     
- Misses        4570     4820     +250     
- Partials         3        4       +1     
Flag Coverage Δ
cpp 73.67% <ø> (ø)
cpp_python 34.35% <ø> (ø)
petab ?
python 72.48% <ø> (ø)
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 18 files with indirect coverage changes

@dweindl
Copy link
Member

dweindl commented Oct 4, 2023

TODO:

  • FAILED tests/testSBMLSuite.py::test_sbml_testsuite_case[2] - UserWarning: Point has no component in this direction. Set ``Computer.relative_size=False`` to avoid this. Using default small step size ``fiddy.EPSILON``: 1e-05
  • FAILED tests/testSBMLSuite.py::test_sbml_testsuite_case[51] - RuntimeWarning: Mean of empty slice
  • FAILED tests/testSBMLSuite.py::test_sbml_testsuite_case[164] - ValueError: cannot reshape array of size 2 into shape (51,2,2)
  • FAILED tests/testSBMLSuite.py::test_sbml_testsuite_case[198] - ValueError: all input arrays must have the same shape
  • For now, skip gradient checks for all models that require further hyperparameter tuning

Copy link

sonarcloud bot commented Feb 27, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants