Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Update Windows installation instructions #2153

Merged
merged 1 commit into from
Jul 30, 2023
Merged

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jul 28, 2023

/LIBPATH doesn't seem to be compatible with ninja. See #2151.

@dweindl dweindl requested a review from a team as a code owner July 28, 2023 10:55
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #2153 (74ab68d) into develop (3cccbb5) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2153   +/-   ##
========================================
  Coverage    76.67%   76.67%           
========================================
  Files           82       82           
  Lines        14943    14943           
========================================
  Hits         11457    11457           
  Misses        3486     3486           
Flag Coverage Δ
cpp 73.55% <ø> (ø)
petab 54.26% <ø> (ø)
python 77.29% <ø> (ø)
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@dweindl dweindl self-assigned this Jul 28, 2023
Copy link
Member

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl dweindl added this pull request to the merge queue Jul 30, 2023
@dweindl dweindl removed this pull request from the merge queue due to a manual request Jul 30, 2023
@dweindl dweindl merged commit 515a68a into develop Jul 30, 2023
15 of 16 checks passed
@dweindl dweindl deleted the doc_windows_install branch July 30, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants