Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA: split into smaller jobs #2204

Merged
merged 6 commits into from
Nov 21, 2023
Merged

GHA: split into smaller jobs #2204

merged 6 commits into from
Nov 21, 2023

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Nov 17, 2023

Split current C++/Python/Notebook tests into three separate workflows:

  1. C++ + some Python
  2. Slow pysb and spline tests
  3. Notebooks

Closes #2195
Closes #2014

Note to self: When adding new jobs in a PR from a fork, those runs will only show up on the fork, not on the PR target.

Split current C++/Python/Notebook tests into three separate workflows.

Closes #2195
Closes #2014
@dweindl dweindl changed the base branch from master to develop November 17, 2023 07:11
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #2204 (3063232) into develop (3330ccb) will decrease coverage by 0.16%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2204      +/-   ##
===========================================
- Coverage    76.68%   76.53%   -0.16%     
===========================================
  Files           82       82              
  Lines        15012    15012              
===========================================
- Hits         11512    11489      -23     
- Misses        3500     3523      +23     
Flag Coverage Δ
cpp 73.06% <ø> (-0.55%) ⬇️
cpp_python 36.99% <ø> (?)
petab 53.80% <ø> (ø)
python 77.23% <ø> (ø)
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

@dweindl dweindl marked this pull request as ready for review November 17, 2023 08:46
@dweindl dweindl requested a review from a team as a code owner November 17, 2023 08:46
@dweindl
Copy link
Member Author

dweindl commented Nov 17, 2023

Ubuntu tests now finish in <30min each. Not sure if we want to split OSX tests too, or only run a subset there, since OSX runners are anyways limited.

Copy link

sonarcloud bot commented Nov 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dweindl dweindl merged commit a4a0b49 into develop Nov 21, 2023
18 of 21 checks passed
@dweindl dweindl deleted the gha_split branch November 21, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants