Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor event handling #2216

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Refactor event handling #2216

merged 2 commits into from
Dec 1, 2023

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Dec 1, 2023

Just extracting 2 functions. No change in functionality.

Just extracting 2 functions. No change in functionality.
@dweindl dweindl requested a review from a team as a code owner December 1, 2023 08:13
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Merging #2216 (82fde3f) into develop (c174c40) will decrease coverage by 22.81%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #2216       +/-   ##
============================================
- Coverage    76.58%   53.77%   -22.81%     
============================================
  Files           91       43       -48     
  Lines        15028     5668     -9360     
============================================
- Hits         11509     3048     -8461     
+ Misses        3519     2620      -899     
Flag Coverage Δ
cpp ?
cpp_python ?
petab 53.77% <ø> (ø)
python ?
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 66 files with indirect coverage changes

@dweindl dweindl self-assigned this Dec 1, 2023
@dweindl dweindl merged commit 06f6217 into AMICI-dev:develop Dec 1, 2023
9 of 10 checks passed
@dweindl dweindl deleted the refactor_event branch December 1, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants