Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup unused includes #2217

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Dec 1, 2023

+clang-format

@dweindl dweindl requested a review from a team as a code owner December 1, 2023 08:23
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Merging #2217 (098d5a1) into develop (67c9ca9) will decrease coverage by 22.73%.
Report is 2 commits behind head on develop.
The diff coverage is n/a.

❗ Current head 098d5a1 differs from pull request most recent head 24e25ab. Consider uploading reports for the commit 24e25ab to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #2217       +/-   ##
============================================
- Coverage    76.50%   53.77%   -22.73%     
============================================
  Files           86       43       -43     
  Lines        15019     5668     -9351     
============================================
- Hits         11490     3048     -8442     
+ Misses        3529     2620      -909     
Flag Coverage Δ
cpp ?
cpp_python ?
petab 53.77% <ø> (+0.02%) ⬆️
python ?
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 81 files with indirect coverage changes

Copy link
Member

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl dweindl merged commit fbb2936 into AMICI-dev:develop Dec 1, 2023
11 of 15 checks passed
@dweindl dweindl deleted the cleanup_includes branch December 1, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants