Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Fix model debug builds #2222

Merged
merged 2 commits into from
Dec 3, 2023
Merged

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Dec 1, 2023

Debug flags were set too late so that most of the model extension was built without them.

Debug flags were set too late so that most of the model extension was built without them.
@dweindl dweindl requested a review from a team as a code owner December 1, 2023 21:59
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Merging #2222 (014d348) into develop (dff4ec3) will decrease coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2222      +/-   ##
===========================================
- Coverage    76.50%   76.46%   -0.04%     
===========================================
  Files           91       91              
  Lines        15034    15034              
===========================================
- Hits         11502    11496       -6     
- Misses        3532     3538       +6     
Flag Coverage Δ
cpp 73.01% <ø> (-0.07%) ⬇️
cpp_python 37.03% <ø> (ø)
petab 53.77% <ø> (ø)
python 77.13% <ø> (ø)
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@dweindl dweindl self-assigned this Dec 1, 2023
@dweindl dweindl merged commit 8962b83 into AMICI-dev:develop Dec 3, 2023
18 of 19 checks passed
@dweindl dweindl deleted the fix_cmake_dbg branch December 11, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants