Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix capturing SUNDIALS warnings after 7.1.1 upgrade #2551

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Oct 18, 2024

Disable SUNDIALS's warning-handling through SUNLogger. Instead pipe everything both errors and warnings through the providedSUNErrHandlerFn.

For details, see #2550.

Fixes #2550.

This also corrects the error message formatting - file path and line numbers for debug builds, but omitted in release builds - which was inverted before.


Previously (see red box): https://amici.readthedocs.io/en/develop/example_errors.html#Internal-t-=-[...]-and-h-=-[...]-are-such-that-t-+-h-=-t-on-the-next-step
Now: https://amici--2551.org.readthedocs.build/en/2551/example_errors.html#Internal-t-=-[...]-and-h-=-[...]-are-such-that-t-+-h-=-t-on-the-next-step

Disable SUNDIALS's warning-handling through `SUNLogger`.
Instead pipe everything both errors and warnings through
the provided`SUNErrHandlerFn`.

For details, see AMICI-dev#2550.

Fixes AMICI-dev#2550.
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.75%. Comparing base (c8778e5) to head (62ef501).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2551   +/-   ##
========================================
  Coverage    77.75%   77.75%           
========================================
  Files          325      325           
  Lines        21852    21852           
  Branches      1473     1473           
========================================
  Hits         16991    16991           
  Misses        4834     4834           
  Partials        27       27           
Flag Coverage Δ
cpp 73.62% <ø> (ø)
cpp_python 34.20% <ø> (ø)
petab 37.06% <ø> (ø)
python 72.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/amici.cpp 79.16% <ø> (ø)
src/solver.cpp 78.49% <ø> (ø)
src/solver_cvodes.cpp 70.76% <ø> (ø)
src/solver_idas.cpp 38.59% <ø> (ø)

@dweindl dweindl self-assigned this Oct 18, 2024
@dweindl dweindl marked this pull request as ready for review October 18, 2024 07:01
@dweindl dweindl requested a review from a team as a code owner October 18, 2024 07:01
@dweindl dweindl merged commit 8253a97 into AMICI-dev:develop Oct 18, 2024
19 of 20 checks passed
@dweindl dweindl deleted the fix_2550_sunlog branch October 18, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants