Fix capturing SUNDIALS warnings after 7.1.1 upgrade #2551
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable SUNDIALS's warning-handling through
SUNLogger
. Instead pipe everything both errors and warnings through the providedSUNErrHandlerFn
.For details, see #2550.
Fixes #2550.
This also corrects the error message formatting - file path and line numbers for debug builds, but omitted in release builds - which was inverted before.
Previously (see red box): https://amici.readthedocs.io/en/develop/example_errors.html#Internal-t-=-[...]-and-h-=-[...]-are-such-that-t-+-h-=-t-on-the-next-step
Now: https://amici--2551.org.readthedocs.build/en/2551/example_errors.html#Internal-t-=-[...]-and-h-=-[...]-are-such-that-t-+-h-=-t-on-the-next-step