Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem ID and output in benchmark collection tests #2570

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Oct 25, 2024

  • Reference value wasn't found for Fiedler_BMCSystBiol2016, because it was recently renamed
  • Print all rows from gradient check results

* Reference value wasn't found for Fiedler_BMCSystBiol2016, because it was recently renamed
* Print all rows from gradient check results
@dweindl dweindl requested a review from a team as a code owner October 25, 2024 06:14
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.75%. Comparing base (f5fa6cd) to head (4661ee2).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2570   +/-   ##
========================================
  Coverage    77.75%   77.75%           
========================================
  Files          325      325           
  Lines        21857    21857           
  Branches      1473     1473           
========================================
  Hits         16996    16996           
  Misses        4834     4834           
  Partials        27       27           
Flag Coverage Δ
cpp 73.63% <ø> (ø)
cpp_python 34.20% <ø> (ø)
petab 37.07% <ø> (ø)
python 72.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dweindl dweindl added this pull request to the merge queue Oct 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 25, 2024
@FFroehlich FFroehlich added this pull request to the merge queue Oct 25, 2024
Merged via the queue into AMICI-dev:develop with commit ff6b3f1 Oct 25, 2024
20 checks passed
@dweindl dweindl deleted the fix_benchmark_tests branch October 25, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants