Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only print mid-timestep estTimeStep outputs if relevant #3023

Merged
merged 6 commits into from
Jan 20, 2025
Merged

Only print mid-timestep estTimeStep outputs if relevant #3023

merged 6 commits into from
Jan 20, 2025

Conversation

maxpkatz
Copy link
Member

PR summary

Output from estTimeStep is occurring for the pre- and post-timestep validity checks, but on most timesteps this clutters the output because the validity check passes. This PR creates a class that temporarily redirects std::cout and then uses that to capture the estTimeStep output and only print it if needed.

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@maxpkatz maxpkatz marked this pull request as ready for review January 20, 2025 18:42
@zingale zingale merged commit f7c5311 into AMReX-Astro:development Jan 20, 2025
25 checks passed
@maxpkatz maxpkatz deleted the cout_redirection branch January 20, 2025 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zingale zingale zingale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxpkatz @zingale