-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add neutrino loses to NSE table with SDC #1357
Conversation
I decided to run convergence test with nse_net and sdc for this pr, I get lower energy convergence
vs. before:
Is this expected? |
That's interesting. To be honest, I don't understand the energy convergence yet. I'm struggling with that with the tabular stuff. |
do you observe the same thing (lower convergence) with tabular nse? |
I am not sure. I need to rerun to see what happens with the old version. |
I don't see much difference when I remove the neutrino stuff with the table. It's possible that with the self-consistent NSE that I am not time-centering things correctly. |
I think that this convergence is fine. We would expect the integral quantities to converge as second order, but rho_enuc is a derivative, which means we divide by dt, so we lose an order of convergence there. I think that the diffs here result from the enuc term being larger in this PR -- note the size of the norm. |
No description provided.