Feat/#5 week3 #6

hyoeunjoo · 2024-11-01T13:05:45Z

Related issue 🛠

closed [FEAT] 3주차 과제 구현 #5

Work Description ✏️

+텍스트필드 컴포넌트로 빼면서 전에 못했던 회원가입 형식에 맞지 않으면 stroke 빨간색으로 뜨게 했습니다

Screenshot 📸

Screen_recording_20241101_215559.mp4

Uncompleted Tasks 😅

원래 있던 부분들은 컴포넌트화 진행했는데
원래 없었던 sticky header부분은 해보고싶었는데 완료하지 못했습니닿.. 다음주에 sticky까지 같이 넣어볼게요!

To Reviewers 📢

컴포넌트 찾고 뷰스케치한 부분은 아래 노션 참고해주세요!
https://rightful-narwhal-db9.notion.site/3-131037058d208073a5f1c9db0bcb5073?pvs=4

imtaejugkim

시험기간에도 과제 하시느라 고생 많으셨어요! 기존에 Component화를 잘하셔서 뭔가 막힘없이 과제 하신 것 같아 저도 앞으로 본받아야겠다고 생각한 코드였습니다..! 코드리뷰 바탕으로 제 코드도 보완해보겠습니당

imtaejugkim · 2024-11-03T11:02:02Z

app/src/main/java/org/sopt/and/component/CustomHeader.kt

+fun CustomHeader(
+    startIcon: @Composable (() -> Unit)? = null,
+    centerContent: @Composable () -> Unit,
+    endIcon: @Composable (() -> Unit)? = null


top bar의 배치가 다 달라서 컴포넌트화를 시킬 수 있을까 의문이었는데, 컴포저블하게 람다함수를 통해 각 아이콘과 컨텐츠 배치가 가능하군요..! 제 고민을 한번에 해결해준 코드였습니다.

imtaejugkim · 2024-11-03T11:06:39Z

app/src/main/java/org/sopt/and/component/textfield/CustomEmailTextField.kt

+    placeholderColor: Color = Color(0xFFA5A5A5),
+    focusedBorderColor: Color = Color(0xFF2F2F2F),
+    unfocusedBorderColor: Color = Color(0xFF2F2F2F),
+    errorBorderColor: Color = Color.Red


에러 처리까지..! 저는 몰랐는데, 제가 웨이브 앱을 안써보고 해서 오류 표시를 안했네요..ㅎㅎ 꼼꼼함에 엄지를 드립니다!

imtaejugkim · 2024-11-03T11:08:06Z

app/src/main/java/org/sopt/and/feature/login/LoginScreen.kt

@@ -116,7 +120,7 @@ fun LoginScreen(navController: NavController) {
        }

        Spacer(modifier = Modifier.padding(top = 20.dp))
-        ThreeTextsWithDividers(
+        FindIdPwOrSignUp(


가독성이 좋은 컴포넌트 이름!

imtaejugkim · 2024-11-03T11:09:53Z

app/src/main/java/org/sopt/and/feature/signup/SignUpViewModel.kt

    }

    fun isValidEmail(email: String): Boolean {
        return Patterns.EMAIL_ADDRESS.matcher(email).matches()
    }

-    fun isValidPassword(password: String): Boolean {
+    private fun isValidPassword(password: String): Boolean {


viewModel 내에서만 정의되는 함수를 접근 제어자로 변경한 것이 좋은 것 같아요

sayyyho

바쁘셨을텐데 이번주도 고생 많았습니다!! 항상 많이 배워갑니다!!

sayyyho · 2024-11-03T14:16:18Z

app/src/main/java/org/sopt/and/component/CustomHeader.kt

+@Composable
+fun CustomHeader(
+    startIcon: @Composable (() -> Unit)? = null,
+    centerContent: @Composable () -> Unit,
+    endIcon: @Composable (() -> Unit)? = null


Compose UI와 null로 여러 케이스를 고려하여 컴포넌트를 할 수 있겠군요! 저도 많이 배워갑니다!

넵..! 해보긴 했는데 좋은 방법인지는 잘 모르겠슴다 ㅎㅎ

sayyyho · 2024-11-03T14:34:59Z

app/src/main/java/org/sopt/and/component/textfield/CustomPwTextField.kt

+fun CustomPwTextField(
+    value: String,
+    onValueChange: (String) -> Unit,
+    modifier: Modifier = Modifier,
+    placeholder: String,
+    isError: Boolean = false,
+    errorMessage: String? = null,
+    textColor: Color = Color.White,
+    placeholderColor: Color = Color(0xFFA5A5A5),
+    focusedBorderColor: Color = Color(0xFF2F2F2F),
+    unfocusedBorderColor: Color = Color(0xFF2F2F2F),
+    errorBorderColor: Color = Color.Red
+) {


CustomPwTextField도 많은 점을 배워갑니다. 여러 사용 케이스에서 인자별로 어떻게 처리할 지 고민이었는데, 이 부분 고민은 말끔하게 해소됩니다.

sayyyho · 2024-11-03T14:37:25Z

app/src/main/java/org/sopt/and/feature/login/LoginScreen.kt

+        CustomPwTextField(
+            value = loginPassword,
+            onValueChange = { viewModel.updatePassword(it) },
+            placeholder = stringResource(R.string.login_setting_password),
+            modifier = Modifier.padding(vertical = 10.dp)
+        )


선언에 이은 실제 사용까지 진짜 공부 많이 됐습니다!

sayyyho · 2024-11-03T14:38:22Z

app/src/main/java/org/sopt/and/feature/login/LoginScreen.kt

        Spacer(modifier = Modifier.padding(top = 30.dp))

        NavigateToMain {
            viewModel.login(userInfo)
        }

        LaunchedEffect(isLoginSuccessful) {
-            isLoginSuccessful?.let {
+            isLoginSuccessful.let {


혹시 ?를 빼신 이유가 있을까요? 궁금합니다!

뷰모델에서 해당 isLoginSuccessful을 Boolean 값으로 설정해줬습니다! 더이상 널체크할 이유가 사라졌기 때문이에용

구러면 let문이 없어도 될 것 같네요.

kez-lab

3주차도 넘 고생 많으셨습니다!?
이번주는 크게 볼 부분은 없을 것 같아서! 간단히 코멘트만 남겨두었어요~!!

kez-lab · 2024-11-03T23:53:37Z

app/src/main/java/org/sopt/and/component/CustomHeader.kt

+@Composable
+fun CustomHeader(
+    startIcon: @Composable (() -> Unit)? = null,


https://developer.android.com/develop/ui/compose/components/app-bars
요거 참고해보는 것도? 왠만하면 유지보수 차원이나 확장성 차원에서 커스텀뷰보단 안드로이드에서 지원하는 기본 기능을 쓰는게 좋습니당

아..! 그렇겠네요 감사합니다 ㅎㅎ

jihyunniiii

고생했더요 ~

jihyunniiii · 2024-11-06T08:41:10Z

app/src/main/java/org/sopt/and/component/textfield/CustomEmailTextField.kt

+    value: String,
+    onValueChange: (String) -> Unit,
+    modifier: Modifier = Modifier,
+    placeholder: String,


필수값이 먼저 !!! 오게 해주세용 ~

jihyunniiii · 2024-11-06T08:43:44Z

app/src/main/java/org/sopt/and/component/textfield/CustomPwTextField.kt

+import androidx.compose.runtime.setValue
+
+@Composable
+fun CustomPwTextField(


세미나 때 잠깐 말했던 것처럼 Basic한 텍스트 필드를 만들고 이를 통해서 PwText와 idText를 만드는 것도 좋을 것 같아요.
물론 정답은 없지만 갠취 ~

jihyunniiii · 2024-11-06T08:44:09Z

app/src/main/java/org/sopt/and/component/textfield/CustomPwTextField.kt

+import androidx.compose.runtime.setValue
+
+@Composable
+fun CustomPwTextField(


줄임말을 사용해서 네이밍 하기보다는 풀어서 작성하시는 것이 좋습니다 !
딱 보고 어떤 값인지 알 수 있게요!

jihyunniiii · 2024-11-06T09:33:13Z

app/src/main/java/org/sopt/and/feature/login/LoginScreen.kt

        Spacer(modifier = Modifier.padding(top = 30.dp))

        NavigateToMain {
            viewModel.login(userInfo)
        }

        LaunchedEffect(isLoginSuccessful) {
-            isLoginSuccessful?.let {
+            isLoginSuccessful.let {


구러면 let문이 없어도 될 것 같네요.

jihyunniiii · 2024-11-06T09:33:30Z

app/src/main/java/org/sopt/and/feature/login/LoginScreen.kt

+fun FindIdPwOrSignUp(
    modifier: Modifier = Modifier,
-    text1: String,
-    text2: String,
-    text3: String,
+    findId: String,
+    reSettingPw: String,
+    signUp: String,


좋네요오오

hyoeunjoo added 4 commits November 1, 2024 20:01

#5 [add] 공통 textfield component 생성

bf03b1d

#5 [fix] textfield 컴포넌트를 이용

5af6128

#5 [add] CustomHeader component 생성

02b016d

#5 [fix] CustomHeader 이용

a7b404d

hyoeunjoo requested review from sayyyho, imtaejugkim and jihyunniiii November 1, 2024 13:05

imtaejugkim approved these changes Nov 3, 2024

View reviewed changes

sayyyho approved these changes Nov 3, 2024

View reviewed changes

kez-lab reviewed Nov 5, 2024

View reviewed changes

jihyunniiii reviewed Nov 6, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/#5 week3 #6

Feat/#5 week3 #6

hyoeunjoo commented Nov 1, 2024 •

edited

Loading

imtaejugkim left a comment

imtaejugkim Nov 3, 2024

imtaejugkim Nov 3, 2024

imtaejugkim Nov 3, 2024

imtaejugkim Nov 3, 2024

sayyyho left a comment

sayyyho Nov 3, 2024

hyoeunjoo Nov 5, 2024

sayyyho Nov 3, 2024

sayyyho Nov 3, 2024

sayyyho Nov 3, 2024

hyoeunjoo Nov 5, 2024

jihyunniiii Nov 6, 2024

kez-lab left a comment

kez-lab Nov 3, 2024

hyoeunjoo Nov 5, 2024

jihyunniiii left a comment

jihyunniiii Nov 6, 2024

jihyunniiii Nov 6, 2024

jihyunniiii Nov 6, 2024

jihyunniiii Nov 6, 2024

jihyunniiii Nov 6, 2024

Feat/#5 week3 #6

Are you sure you want to change the base?

Feat/#5 week3 #6

Conversation

hyoeunjoo commented Nov 1, 2024 • edited Loading

Related issue 🛠

Work Description ✏️

Screenshot 📸

Uncompleted Tasks 😅

To Reviewers 📢

imtaejugkim left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sayyyho left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kez-lab left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jihyunniiii left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hyoeunjoo commented Nov 1, 2024 •

edited

Loading