Feature composer config #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add scripts to execute unit and functional tests. - Remove "typo3/cms-core" from extension dependencies. - Use distribution version of TYPO3 source for development. - Add support info.
Introduce namespace.
Specify global namespace prefix to tx_t3deploy_databaseController class.
tomasnorre
reviewed
Jan 15, 2018
composer.json
Outdated
| "[ -e '.Build/bin/phpunit' ] || composer update", | ||
| "TYPO3_PATH_ROOT=$(pwd)/.Build/Web .Build/bin/phpunit --colors -c .Build/vendor/nimut/testing-framework/res/Configuration/FunctionalTests.xml Tests/Functional" | ||
| ], | ||
| "test:params": [ |
There was a problem hiding this comment.
Please remove this block. this was only for PoC in the composer meeting.
There was a problem hiding this comment.
It has been removed now.
Remove redundant configuration.
srotsch
reviewed
Jan 15, 2018
| @@ -1,4 +1,6 @@ | |||
| <?php | |||
| namespace Aoe\t3deploy\Tests\Functional; | |||
There was a problem hiding this comment.
I would opt for UpperCamelCase in the namespace, thus Aoe\T3deploy\Tests\Functional.
Even though not being explicitly stated in PSR-4, this feels like an implicit convention to me, at least in the TYPO3 context.
There was a problem hiding this comment.
I realised this later. It has been fixed in "feature-implement-namespace" branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.