Refactor Routing Logic for Proper Conditional Layout Rendering #287
+12
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the routing logic in AppRoutes.tsx to correctly handle conditional rendering of layout routes.
Changes Made:
Separated Initial Route: The /initial route is now handled independently and does not render the layout wrapper.
Fixed Layout Wrapping: The layout () is now applied only to routes that match entries in ROUTES.LAYOUT, using path="/*" to catch all layout routes.
Improved Routing Logic: Conditional rendering of layout routes is streamlined, ensuring proper handling of both layout and non-layout pages.
Reason for Change:
To ensure that the layout wrapper is applied correctly to relevant routes while keeping the /initial page unaffected by the layout.
Expected Behavior:
The /initial route renders without the layout.
All other routes requiring the layout will render correctly within the layout wrapper.
Related Issue: This change addresses the issue raised in #286 , which highlights the incorrect conditional rendering of layout routes.