Summary QC #844
Summary QC #844
Conversation
… with the web API. Need to request Reprocessed assessment type to get the test to work.
…ariable when it only has a time dimension but data has time/height
kenkehoe
requested review from
AdamTheisen,
zssherman and
mgrover1
as code owners
|
Don't integrate the PR yet. I need to discuss current implementation with Adam and Michael first. |
|
@kenkehoe Thanks for the PR! I added some review comments |
|
@kenkehoe Cool with me merging this? I saw Adam approved it |
…sed on QC variable shape instead of assuming data and qc are the same size.
… is from SIRS SERI QC. If so will run an additional method to convert from SERI QC to standardized QC.
…to update the QC varible in place so the order of variables are preserved.
|
@kenkehoe looks like some linting/pep8 errors |
|
@kenkehoe You cool with me merging this? |
|
@zssherman hold off on merger. I found one more issue and I need to run some more testing. Hopefully this will be figured out soon. |
|
@kenkehoe No worries at all! |
…ucture of the data file.
…tching between single and big processing.
|
@kenkehoe how's this looking for merging? @zssherman have your requested changes been implemented? Can we resolve that request? |
|
@AdamTheisen I believe this ready to merge. I have tested the crap out of this and it is working pretty well. My only issue currently is with the arm-test-data repo when used as a clone vs. PIP install. |
|
@kenkehoe Thanks for doing those changes! Merging |
This PR contains a new method to create the Standardized QC Summary file. It will convert current embedded QC which is bit packed to integer/flag QC that contains a single test per assessment. Plan is for ADC Data Discovery to use this code to generate QC Summary files on the fly for user order. This is part of ARM TSK0312159.