Nn/nonsquare 1d #592
Open
Nn/nonsquare 1d #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
May 9, 2019 12:53
…ic test for 1d pooling
|
Can one of the admins verify this patch? |
JonatanAntoni
force-pushed
the
develop
branch
from
c9155d1
to
1b35075
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed four reference functions for non-square and 1D pooling (Max and Ave). It doesn't make a bunch of sense to have non-square CNNS but not non-square pooling as referenced in issue 455 ( #455) Also added the 1D convolution because it can be done slightly faster by separating it into its own function. I also added 1D wrappers around the non-square CNN functions to allow simplified code for 1D CNNs to work with the 1D pooling. This would make issue 541 simpler. ( #541 ) I didn't seperate the CNN's into their own functions because there was not an obvious potential to save OPs
Note I did add test to the test code but I don't have Keil so I haven't tested my implementations so there are probably bugs in the shapes of the Non-Square functions