This repository has been archived by the owner on Jan 15, 2021. It is now read-only.
Convert FunctionPointer to use variadic templates #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires C++11 support. C++11 is currently turned off on mbed.
|
Sorry, I'm a bit confused. If this change requires C++11 and turning it on manually 'breaks a lot of things', why do we think this change is good enough to merge into core-util? I think I'm missing something, but I don't know what. |
|
Maybe I didn't explain this properly. This code is ready for merge. The targets need to have C++11 enabled and turning on
I will make a PR to enable C++11 support in target-mbed-gcc/target-mbed-armcc, but we can't merge those until we fix some problems in other modules. |
|
will this make it in before code freeze? |
|
No. C++11 will not be enabled for our next release. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires C++11 support.
C++11 is currently turned off on mbed. Turning it on manually breaks a lot of things.
This code is tested on my host, but I cannot currently compile it for mbed.
@bogdanm @hugovincent @0xc0170 @salkinium