-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade openapi after subscriptions removal #1821
Upgrade openapi after subscriptions removal #1821
Conversation
The |
The version conflict should be resolved by the most recent version of |
We can now upgrade the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I can tell, this PR look good. I'm confident in the changes to our configuration YAMLs, the dependabot changes, the changelog, and requirements files.
However, I have not worked with Flask APIs in the past, and thus don't feel good rubber stamping the changes in apps/api/src/hyp3_api/routes.py
. Would @jhkennedy or @asjohnston-asf be willing to lend a hand here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! I like the class to decorator change.
See #1193
After removing the Subscriptions feature, we've significantly changed our API spec and have removed the need for WKT string validation, which makes much of the work done on #1708 obsolete, so I'm starting over from scratch with this PR.
This PR includes the following changes:
openapi-core
,openapi-spec-validator
, andjsonschema
packages to their latest versions@app.route
, which leads to simpler code (in my opinion) and, more importantly, allows us to more easily use theFlaskOpenAPIViewDecorator
decorator provided byopenapi-core
, which in turn allows us to re-implement the following features according to the latestopenapi-core
interface:TODO:
openapi-core
pin back to the normal format following the next PyPI release (see theTODO
comment in the requirements file)