Ensure modac tests are run #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kartstig
force-pushed
the
mm/modac-tests
branch
from
f80c278
to
8286163
Compare
Kartstig
commented
Sep 16, 2024
| TAG = v$(VERSION)-$(SUBTAG) | ||
| else | ||
| TAG = $(PLATFORM)-$(ENV) | ||
| TAG = $(ENV)-$(PLATFORM) |
There was a problem hiding this comment.
I think it makes more sense to use $(ENV)-$(PLATFORM) because then you can just do:
ENV=v1.6.3 PLATFORM=cpu ...
This will be consistent with the way it looks when master is tagged v$(VERSION)-$(SUBTAG)
mauvais2
reviewed
Sep 16, 2024
Kartstig
force-pushed
the
mm/modac-tests
branch
from
a3ccb57
to
4903890
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to wait for the changes in
1.6.3with all the Github Actions code for this to go in, but it's ready now 🎉