Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependencies (#7) and 'ignore_prior' argument #8

Merged
merged 3 commits into from
Jan 30, 2025
Merged

Conversation

EBHolm
Copy link
Collaborator

@EBHolm EBHolm commented Jan 30, 2025

This PR solves #7 and introduces a ignore_prior kernel argument, which overrides the kernel logprior definition with a uniform prior of constant value 1. Note that this is False by default, hence, if one includes non-uniform priors e.g. in a cobaya yaml file, optimisations will find the MAP estimate instead of the maximum likelihood estimate. We leave the default as false since, in my experience, explicit non-uniform priors often come from external empirical constraints (e.g. the ubiquitous BBN prior on omega_b).

@EBHolm EBHolm merged commit e7bd9e3 into main Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant