Retry on error #66
Merged
Retry on error #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/rawdog/__main__.py
Outdated
| @@ -35,9 +36,14 @@ def rawdog(prompt: str, config, llm_client): | |||
| print(message) | |||
| except KeyboardInterrupt: | |||
| error = "Execution interrupted by user" | |||
| except Exception as e: | |||
| error = str(e) | |||
There was a problem hiding this comment.
Now that the python script is run in a subprocess there aren't really very many exceptional cases. Basically just litellm errors and dryrun rejected scripts. In my opinion we shouldn't try to recover from either of them. I think if the user doesn't accept the edits instead of throwing an exception we should break from the loop. Presumably if they didn't like the llm's first attempt they might rather give new information. If they do want to rerun exactly they can ask the same question again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
retriesto the config, to retry generating a script if it raises and exception.