add SpiceClient #2
Conversation
![mentatbot[bot]](https://avatars.githubusercontent.com/in/837875?s=60&v=4){kind=small}
| else: | ||
| response = chat_completion_or_stream.choices[0].message.content | ||
| return response | ||
| raise ValueError(f"Unknown model {model}") |
There was a problem hiding this comment.
Consider adding support for more models or a default model to avoid raising an exception for unknown models. This would make the client more flexible.
spice.py
Outdated
|
|
||
| load_dotenv() |
There was a problem hiding this comment.
It's a good practice to call load_dotenv() at the entry point of the application to ensure environment variables are loaded once and available throughout the application. Consider moving this call outside of the class.
spice.py
Outdated
| else: | ||
| content = chunk.choices[0].delta.content | ||
| if content is not None: | ||
| yield content |
There was a problem hiding this comment.
The check for content is not None might be redundant since you're initializing content to an empty string and only changing it if certain conditions are met. Consider removing this check.
|
MENTAT CODE REVIEW IN ACTIVE DEVELOPMENT. Only in use on mentat and internal repos. Overall, the implementation of the |
Co-authored-by: abanteai-butler[bot] <160964065+abanteai-butler[bot]@users.noreply.github.com>
No description provided.