Fixes plugin on Chart.js 3.5.x / 3.6.x. #88
Conversation
Allows X axis scale to use either 'x' or 'xAxes'.
Update for 'xAxes' scale name.
| // set axis scale | ||
| chart.options.scales.x.min = start; | ||
| chart.options.scales.x.max = end; | ||
| chart.options.scales[xAxisName].min = start; | ||
| chart.options.scales[xAxisName].max = end; |
There was a problem hiding this comment.
Consider that if "xAxisName" is "xAxes" then it's an array, not an single object
There was a problem hiding this comment.
This is not true, all scales in chart.js V3 are single objects
|
|
||
| if (!chart.config.options.scales.x) { | ||
| return | ||
| const xScaleOptions = chart.config.options.scales.x || chart.config.options.scales.xAxes; |
There was a problem hiding this comment.
Would be better to make this a variable that the user can configure in the options for the plugin so that all names you give to your x axis are supported.
Then if no name has been given you can fall back to chart.js's default x axis scale id which is x
There was a problem hiding this comment.
You are, of course, welcome to make any changes you desire.
| @@ -167,15 +168,17 @@ export default { | |||
|
|
|||
| afterEvent: function(chart, event) { | |||
|
|
|||
| if (chart.config.options.scales.x.length == 0) { | |||
| return | |||
| const xScaleOptions = chart.config.options.scales.x || chart.config.options.scales.xAxes; | |||
| @@ -278,6 +281,7 @@ export default { | |||
| }, | |||
|
|
|||
| resetZoom: function(chart) { | |||
| const xAxisName = chart.config.options.scales.x ? 'x' : chart.config.options.scales.xAxes ? 'xAxes' : undefined; | |||
There was a problem hiding this comment.
same as above, just take it from the options and if not specify fall back to default x
|
|
||
| doZoom: function(chart, start, end) { | ||
| const xAxisName = chart.config.options.scales.x ? 'x' : chart.config.options.scales.xAxes ? 'xAxes' : undefined; |
|
Any update on this? This prevents using your library with chart.js 3.5+, which means it effectively works with 3.4.x only. |
|
@AbelHeinsbroek any updates? Would love to get this pulled in. |
|
Hi, any updates on this one? |
|
I will look into this |
Fixes plugin with Chart.js 3.5.x / 3.6.x.
Allows X axis scale to use either 'x' or 'xAxes'.