Bump golang-ci in pipelines (#24)

* Bump golang-ci in pipelines Signed-off-by: Dinar Valeev <[email protected]> * fix linting issues --------- Signed-off-by: Dinar Valeev <[email protected]> Co-authored-by: Michal Kuritka <[email protected]>
AbsaOSS · Nov 5, 2024 · 821c450 · 821c450
1 parent 3fddeb4
commit 821c450
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/.github/workflows/golangci.yaml b/.github/workflows/golangci.yaml
@@ -33,5 +33,5 @@ jobs:
       - name: GolangCI
         uses: golangci/golangci-lint-action@v3
         with:
-          version: v1.55.2
+          version: v1.61.0
           args: --timeout=3m
diff --git a/cmd/webhook/init/dnsprovider/dnsprovider.go b/cmd/webhook/init/dnsprovider/dnsprovider.go
@@ -47,10 +47,10 @@ func Init(config configuration.Config) (provider.Provider, error) {
 			regexp.MustCompile(config.RegexDomainExclusion),
 		)
 	} else {
-		if config.DomainFilter != nil && len(config.DomainFilter) > 0 {
+		if len(config.DomainFilter) > 0 {
 			createMsg += fmt.Sprintf("domain filter: '%s', ", strings.Join(config.DomainFilter, ","))
 		}
-		if config.ExcludeDomains != nil && len(config.ExcludeDomains) > 0 {
+		if len(config.ExcludeDomains) > 0 {
 			createMsg += fmt.Sprintf("exclude domain filter: '%s', ", strings.Join(config.ExcludeDomains, ","))
 		}
 		domainFilter = endpoint.NewDomainFilterWithExclusions(config.DomainFilter, config.ExcludeDomains)

diff --git a/pkg/webhook/webhook.go b/pkg/webhook/webhook.go
@@ -20,6 +20,7 @@ Generated by GoLic, for more details see: https://github.com/AbsaOSS/golic
 
 import (
 	"encoding/json"
+	"errors"
 	"fmt"
 	"net/http"
 
@@ -89,7 +90,7 @@ func (p *Webhook) headerCheck(isContentType bool, w http.ResponseWriter, r *http
 		} else {
 			msg += "an accept header"
 		}
-		err := fmt.Errorf(msg)
+		err := errors.New(msg)
 
 		_, writeErr := fmt.Fprint(w, err.Error())
 		if writeErr != nil {