#99: DBEngine requirement removed from DBSchema. Fixes #99.

[salamonpavel]

DBEngine requirement was removed from the DBSchema class.

[github-actions]

JaCoCo code coverage report - scala 2.11.12

File	Coverage [94.83%]	🍏
DBSchema.scala	94.83%	🍏

Total Project Coverage	49.75%	🍏

[github-actions]

JaCoCo code coverage report - scala 2.12.17

File	Coverage [93.88%]	🍏
DBSchema.scala	93.88%	🍏

Total Project Coverage	50.04%	🍏

[miroslavpojer]

• pulled
• built
• code review
• code coverage - proposed 2 tests by comment.

[miroslavpojer]

I propose to add new tests to improve coverage:

test("schema name with naming convention without override") {
    object LowerCaseNamingConvention extends NamingConvention {
      def stringPerConvention(original: String): String = original.toLowerCase
    }
    class Bar extends DBSchema(LowerCaseNamingConvention, null)

    val schema = new Bar
    assert(schema.schemaName == "bar") // Assuming the naming convention converts "Bar" to "bar"
  }

test("schema name with naming convention with override") {
    object LowerCaseNamingConvention extends NamingConvention {
      def stringPerConvention(original: String): String = original.toLowerCase
    }
    class Bar extends DBSchema(LowerCaseNamingConvention, "bar")

    val schema = new Bar
    assert(schema.schemaName == "bar")
  }

[salamonpavel]

Thank you @miroslavpojer. Will add it to the codebase. I think also that once we merge this code we should revisit existing projects utilizing this library, fix it's usage there and then update examples so users of the library have updated examples as part of this repo.

[salamonpavel]

Added.

[lsulak]

maybe I would chose something other than bar, just to distinguish it? :) I mean, so that the schema name is actually overridden

[lsulak]

Almost approved, found a tiny thing. Since originally there was a dependency on the DBEngine, but it wasn't really used here, I like the changes

[salamonpavel]

This PR has become obsolete.