Revert the addition of Matrix44.setEulerAngles/setAxisAngle from #305

This alters the ABI in what should be a patch release. Signed-off-by: Cary Phillips <[email protected]>
AcademySoftwareFoundation · May 31, 2023 · a061ad9 · a061ad9
1 parent 3ec6904
commit a061ad9
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 31 deletions.
diff --git a/src/python/PyImath/PyImathMatrix44.cpp b/src/python/PyImath/PyImathMatrix44.cpp
@@ -648,22 +648,6 @@ setValue44(Matrix44<T> &mat, const Matrix44<T> &value)
     mat.setValue(value);
 }
 
-template <class T>
-static void
-setEulerAngles44(Matrix44<T> &mat, const Vec3<T> &value)
-{
-    MATH_EXC_ON;
-    mat.setEulerAngles(value);
-}
-
-template <class T>
-static void
-setAxisAngle44(Matrix44<T> &mat, const Vec3<T> &axis, T angle)
-{
-    MATH_EXC_ON;
-    mat.setAxisAngle(axis, angle);
-}
-
 template <class T>
 static const Matrix44<T> &
 shearV44(Matrix44<T> &mat, const Vec3<T> &s)
@@ -1125,8 +1109,6 @@ register_Matrix44()
         .def("setTranslation", &setTranslation44Tuple<T>, return_internal_reference<>(),"setTranslation()")
         .def("setTranslation", &setTranslation44Obj<T>, return_internal_reference<>(),"setTranslation()")
         .def("setValue", &setValue44<T>, "setValue()")
-        .def("setEulerAngles", &setEulerAngles44<T>, "setEulerAngles()")
-        .def("setAxisAngle", &setAxisAngle44<T>, "setAxisAngle()")
         .def("shear", &shearV44<T>, return_internal_reference<>(),"shear()")
         .def("shear", &shearS44<T>, return_internal_reference<>(),"shear()")
         .def("shear", &shear44Tuple<T>, return_internal_reference<>(),"shear()")

diff --git a/src/python/PyImathTest/pyImathTest.in b/src/python/PyImathTest/pyImathTest.in
@@ -6107,19 +6107,6 @@ def testM44x (Mat, Vec):
     m.extractEulerXYZ(v)
     assert v.equalWithAbsError((0, 0, -a), v.baseTypeEpsilon())
 
-    e = Vec(0,0,-a)
-    m.setEulerAngles(e)
-    assert (equal(m[0][0], cos(a), 0.0001))
-    assert (equal(m[0][1], -sin(a), 0.0001))
-    assert (equal(m[1][0], sin(a), 0.0001))
-    assert (equal(m[1][1], cos(a), 0.0001))
-
-    axis = Vec(0,0,1)
-    m.setAxisAngle(axis,-a)
-    assert (equal(m[0][0], cos(a), 0.0001))
-    assert (equal(m[0][1], -sin(a), 0.0001))
-    assert (equal(m[1][0], sin(a), 0.0001))
-    assert (equal(m[1][1], cos(a), 0.0001))
 
     # Extract scale, shear, rotation, translation.