Add pybind11 wrappings for Imath::Frustum #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for issue AcademySoftwareFoundation#428 Created a pybind11 wrapping file based on the specified template. Requires further testing, as this is my first time using pybind11. Signed-off-by: Nikhil Mishra <[email protected]>
The committers listed above are authorized under a signed CLA. |
|
@nmishra-ufl, we'd like to accept this contribution, but would prefer to see the changes noted above, adding the other pieces that hook the code into the existing framework. Would you be able to address those soon? Thanks! |
|
@nmishra-ufl, following up on this again, will you be able to complete the implementation? I can help if you have any questions about what to do. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #428
Created a pybind11 wrapping file based on the specified template. Requires further testing, as this is my first time using pybind11.