Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cuesubmit jobs from config file #1284

Open
wants to merge 89 commits into
base: master
Choose a base branch
from
Open

Cuesubmit jobs from config file #1284

wants to merge 89 commits into from

Commits on Aug 8, 2024

  1. doc!: update cuesubmit example config file with new jobs syntax + hel… 

    …p section
    @KernAttila
    KernAttila committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    7ea1562 View commit details
    Browse the repository at this point in the history

  2. doc!: add a cuesubmit isolated example config file

    @KernAttila
    KernAttila committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    14a0385 View commit details
    Browse the repository at this point in the history

  3. feat: add notEmptyString validator

    @KernAttila
    KernAttila committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    d761fac View commit details
    Browse the repository at this point in the history

  4. feat: extract yaml loading to a function and add one to expand any su… 

    …b `config_file` + error handling
    @KernAttila
    KernAttila committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    72adc3d View commit details
    Browse the repository at this point in the history

  5. feat: load RENDER_CMDS in Constants

    @KernAttila
    KernAttila committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    959613d View commit details
    Browse the repository at this point in the history

  6. feat: add regex to get opencue tokens

    @KernAttila
    KernAttila committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    f26d5ca View commit details
    Browse the repository at this point in the history

  7. feat: add regex to parse options from the cuesubmit config file

    @KernAttila
    KernAttila committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    195091f View commit details
    Browse the repository at this point in the history

  8. feat: add convertCommandOptions() to parse command options from the… 

    … config file
    @KernAttila
    KernAttila committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    0d375d2 View commit details
    Browse the repository at this point in the history

  9. feat: Append jobs from the config file to JobTypes

    @KernAttila
    KernAttila committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    da98b04 View commit details
    Browse the repository at this point in the history

  10. feat: return JobTypes.types dynamically

    @KernAttila
    KernAttila committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    47ac2ef View commit details
    Browse the repository at this point in the history

  11. feat: Associate DynamicSettingsWidget to all jobs from the config file

    @KernAttila
    KernAttila committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    6feddc3 View commit details
    Browse the repository at this point in the history

  12. feat: Convert custom commands options and pass them to the `DynamicSe… 

    …ttingsWidget`
    @KernAttila
    KernAttila committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    03c08b6 View commit details
    Browse the repository at this point in the history

  13. test: add validator test testNotEmptyString

    @KernAttila
    KernAttila committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    2c2bf7a View commit details
    Browse the repository at this point in the history

  14. feat: Add function to build command line for jobs from the config fil… 

    …e + companion functions
    @KernAttila
    KernAttila committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    eef22bd View commit details
    Browse the repository at this point in the history

  15. feat: same optimisation as PR AcademySoftwareFoundation#1283 + recogn… 

    …ize type from config files
    @KernAttila
    KernAttila committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    4ac65a7 View commit details
    Browse the repository at this point in the history

  16. feat: add signals, getter and setter attributes on `CueCommandW… 

    …idget` used in `DynamicSettingsWidget`
    @KernAttila
    KernAttila committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    3ccea48 View commit details
    Browse the repository at this point in the history

  17. feat: add signals, getter and setter attributes on `CueLabelLin… 

    …eEdit` used in `DynamicSettingsWidget`
    @KernAttila
    KernAttila committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    3e60389 View commit details
    Browse the repository at this point in the history

  18. feat: add signals, getter and setter attributes on `CueSelectPu… 

    …llDown` used in `DynamicSettingsWidget`
    @KernAttila
    KernAttila committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    fd924ad View commit details
    Browse the repository at this point in the history

  19. feat: update setter attribute on CueSelectPulldown and add a func… 

    …tion `setCheckedFromText`
    @KernAttila
    KernAttila committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    a254c9a View commit details
    Browse the repository at this point in the history

  20. feat: add signals, getter and setter attributes on `CueLabelTog… 

    …gle` used in `DynamicSettingsWidget`
    @KernAttila
    KernAttila committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    e152336 View commit details
    Browse the repository at this point in the history

  21. feat!: add default value to CueLabelToggle

    @KernAttila
    KernAttila committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    17bc8d2 View commit details
    Browse the repository at this point in the history

  22. fix: test string widget during init, showing missing fields in red fr… 

    …om the beginning
    @KernAttila
    KernAttila committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    3bc307c View commit details
    Browse the repository at this point in the history

  23. fix: skip optional options if they have no value

    @KernAttila
    KernAttila committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    46ea2d8 View commit details
    Browse the repository at this point in the history

  24. fix: setChecked function was not receiving the right data type

    @KernAttila
    KernAttila committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    5d774b3 View commit details
    Browse the repository at this point in the history

  25. fix: change FileExistsError to a proper FileNotFoundError

    @KernAttila
    KernAttila committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    dfb220d View commit details
    Browse the repository at this point in the history

  26. feat: add DynamicSettingsWidget

    @KernAttila
    KernAttila committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    7e6846c View commit details
    Browse the repository at this point in the history

  27. fix: return early, passing tests when no config file is there

    @KernAttila
    KernAttila committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    b9aa0e2 View commit details
    Browse the repository at this point in the history

  28. test: add 2 tests for sub config files when using RENDER_CMDS

    @KernAttila
    KernAttila committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    cb08c88 View commit details
    Browse the repository at this point in the history

  29. doc: add context to the test 

    A missing sub config file will catch the error and forward it to the UI for feedback.
    @KernAttila
    KernAttila committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    3e207cb View commit details
    Browse the repository at this point in the history

  30. fix: test if file exists

    @KernAttila
    KernAttila committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    f873d55 View commit details
    Browse the repository at this point in the history

  31. fix: replace old variable name

    @KernAttila
    KernAttila committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    108670a View commit details
    Browse the repository at this point in the history

  32. pep: add space between functions

    @KernAttila
    KernAttila committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    a84707a View commit details
    Browse the repository at this point in the history

  33. doc: add example for hidden widget without flag adding a value

    @KernAttila
    KernAttila committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    fe1a6d6 View commit details
    Browse the repository at this point in the history

  34. fix: let parent argument at the end

    @KernAttila
    KernAttila committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    161f17b View commit details
    Browse the repository at this point in the history

  35. fix: the Raise here would not work in older versions of python not im… 

    …plementing the f-string "equals" feature yet.
    @KernAttila
    KernAttila committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    1f86dc2 View commit details
    Browse the repository at this point in the history

  36. CueGui, fix service edit (AcademySoftwareFoundation#1293)

    @KernAttila
    KernAttila committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    a8d563c View commit details
    Browse the repository at this point in the history

  37. Abstract logging into seperate classes (RQDLogger and LogReader) (Aca… 

    …demySoftwareFoundation#1429)

**Link the Issue(s) this Pull Request is related to.**
AcademySoftwareFoundation#1401 AcademySoftwareFoundation#1427 

**Summarize your change.**
This abstracts the reading of logs and writing log files. This makes it
simpler to do things like supporting other logging types and conversions
(eg. make sure things are ASCII) in a single class across all platforms.
This is a smaller version of AcademySoftwareFoundation#1401 with just the file logging
abstracted. It also implements the changes from AcademySoftwareFoundation#1427

Co-authored by @ramonfigueiredo and @lithorus

---------

Signed-off-by: Jimmy Christensen <[email protected]>
Co-authored-by: Ramon Figueiredo <[email protected]>
    @lithorus @ramonfigueiredo @KernAttila
    2 people authored and KernAttila committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    ab69f7f View commit details
    Browse the repository at this point in the history

  38. fix: re-add RENDER_CMDS in Constants.py

    @KernAttila
    KernAttila committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    8c5a6ed View commit details
    Browse the repository at this point in the history

  39. fix: add frame tokens in the config example file

    @KernAttila
    KernAttila committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    cfb8fe3 View commit details
    Browse the repository at this point in the history

  40. fix: remove double assignation, upgrade %s to f-string; add *args to … 

    …_setBrowseFolderText(), fix docstring auto formatting
    @KernAttila
    KernAttila committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    ff2bdda View commit details
    Browse the repository at this point in the history

  41. chore: get back changes from master

    @KernAttila
    KernAttila committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    61fcd8d View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. fix: expand widget on 2 rows so they align on the left

    @KernAttila
    KernAttila committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    726a374 View commit details
    Browse the repository at this point in the history

  2. fix: fix layout order

    @KernAttila
    KernAttila committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    1d73834 View commit details
    Browse the repository at this point in the history

  3. fix: lint, remove unused args/kwargs

    @KernAttila
    KernAttila committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    60551e8 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into cuesubmit-jobs-from-config-file

    @KernAttila
    KernAttila authored Aug 15, 2024
    Configuration menu
    Copy the full SHA
    743e180 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'cuesubmit-jobs-from-config-file' of https://github.com/… 

    …Wolf-Pipeline/OpenCue into cuesubmit-jobs-from-config-file
    @KernAttila
    KernAttila committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    af4f5dc View commit details
    Browse the repository at this point in the history

  6. fix: use raw string for regex

    @KernAttila
    KernAttila committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    5556f11 View commit details
    Browse the repository at this point in the history

  7. fix: lint, line too long

    @KernAttila
    KernAttila committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    5ae3145 View commit details
    Browse the repository at this point in the history

  8. fix: lint, lines too long

    @KernAttila
    KernAttila committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    ed56fc5 View commit details
    Browse the repository at this point in the history

  9. chore: extract hide widget functionality from nested if

    @KernAttila
    KernAttila committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    ecc71a4 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' into cuesubmit-jobs-from-config-file

    @KernAttila
    KernAttila authored Aug 15, 2024
    Configuration menu
    Copy the full SHA
    69d118f View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Merge branch 'master' into cuesubmit-jobs-from-config-file

    @KernAttila
    KernAttila authored Aug 19, 2024
    Configuration menu
    Copy the full SHA
    b942729 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Merge branch 'master' into cuesubmit-jobs-from-config-file

    @KernAttila
    KernAttila authored Aug 21, 2024
    Configuration menu
    Copy the full SHA
    490bc8d View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. doc: fix nuke example to be browsable

    @KernAttila
    KernAttila committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    04d3a06 View commit details
    Browse the repository at this point in the history

  2. doc: add "services" and "limits" presets for each job type.

    @KernAttila
    KernAttila committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    288adda View commit details
    Browse the repository at this point in the history

  3. feat: add DEFAULT_SHOW to the cuesubmit config file and use it in the… 

    … UI.
    @KernAttila
    KernAttila committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    8f82fa5 View commit details
    Browse the repository at this point in the history

  4. feat: option to have services and limits preset for each job type dir… 

    …ectly from the config file.
    @KernAttila
    KernAttila committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    c620039 View commit details
    Browse the repository at this point in the history

  5. feat: re-order buttons under the job layer list widget (put arrows to… 

    …gether instead of each end).

Also make the table expand vertically as it is the only widget that should expand in the UI.
    @KernAttila
    KernAttila committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    c4cd63e View commit details
    Browse the repository at this point in the history

  6. feat: add validator to match any integer, even negative

    @KernAttila
    KernAttila committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    0a9501c View commit details
    Browse the repository at this point in the history

  7. refactor: only override job minCores if it is explicitly overridden

    @KernAttila
    KernAttila committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    0076500 View commit details
    Browse the repository at this point in the history

  8. feat: rename greyOut() to disable(), add enable() and toggled() funct… 

    …ions.

Add textChanged signal
    @KernAttila
    KernAttila committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    fb7967d View commit details
    Browse the repository at this point in the history

  9. feat: add option to make CueLineEdit toggleable (and optionally put t… 

    …he layout horizontal)

Add stateChanged signal
    @KernAttila
    KernAttila committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    4ef105d View commit details
    Browse the repository at this point in the history

  10. feat: CueSelectPulldown: add tooltip and select proper option.

    @KernAttila
    KernAttila committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    5b6c204 View commit details
    Browse the repository at this point in the history

  11. feat: CueLabelToggle: add tooltip, fix layout and make label clickabl… 

    …e to trigger the toggle.
    @KernAttila
    KernAttila committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    9275e3a View commit details
    Browse the repository at this point in the history

  12. chore: remove ghost spacer item in helpWidget

    @KernAttila
    KernAttila committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    fe4d549 View commit details
    Browse the repository at this point in the history

  13. chore: DynamicSettingsWidget: manage sizePolicy to avoid it expanding.

    @KernAttila
    KernAttila committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    23075d4 View commit details
    Browse the repository at this point in the history

  14. feat: add option to override min cores.

    @KernAttila
    KernAttila committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    4b97913 View commit details
    Browse the repository at this point in the history

  15. chore: add tooltips and re-order UI to gather related widgets.

    @KernAttila
    KernAttila committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    43ca5e9 View commit details
    Browse the repository at this point in the history

  16. feat: add overrideCores option during job submission.

    @KernAttila
    KernAttila committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    f385cc0 View commit details
    Browse the repository at this point in the history

  17. Merge branch 'AcademySoftwareFoundation:master' into cuesubmit-jobs-f… 

    …rom-config-file
    @KernAttila
    KernAttila authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    9629f6c View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2024

  1. chores: fix pylint issues

    @KernAttila
    KernAttila committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    47daaa6 View commit details
    Browse the repository at this point in the history

  2. test: update test with the override setting

    @KernAttila
    KernAttila committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    fb91f2f View commit details
    Browse the repository at this point in the history

  3. fix: forgot overrideCore argument in the buildFactory.

    @KernAttila
    KernAttila committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    82e98f1 View commit details
    Browse the repository at this point in the history

  4. test: handle connection error to pass the tests (no cuebot available … 

    …during CI)
    @KernAttila
    KernAttila committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    06368cc View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2024

  1. fix: for backward compatibility, check if we override cores by testin… 

    …g if "cores" is not None. If it has an explicit value (like in existing implementations), this means we want to override the value, which is the default behavior.

Otherwise, we let the server assign the value of selected service.
    @KernAttila
    KernAttila committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    3c0a053 View commit details
    Browse the repository at this point in the history

  2. fix: revert to default behavior, we do not override only if the "core… 

    …s" value is None.
    @KernAttila
    KernAttila committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    731bf80 View commit details
    Browse the repository at this point in the history

  3. fix: revert to default behavior, we do not override only if the "core… 

    …s" value is None.
    @KernAttila
    KernAttila committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    f7062af View commit details
    Browse the repository at this point in the history

  4. fix: only send "cores" to pyoutline, "overrideCores" is only set in c… 

    …uesubmit.
    @KernAttila
    KernAttila committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    01d3fb2 View commit details
    Browse the repository at this point in the history

  5. fix: better UI scaling

    @KernAttila
    KernAttila committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    b3408cc View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into cuesubmit-jobs-from-config-file 

    Signed-off-by: Kern Attila GERMAIN <[email protected]>
    @KernAttila
    KernAttila authored Sep 28, 2024
    Configuration menu
    Copy the full SHA
    34f2fea View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2024

  1. fix: lint line too long

    @KernAttila
    KernAttila committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    1bb0b7a View commit details
    Browse the repository at this point in the history

  2. fix: Make sure we use threads for backward compatibility. We check if… 

    … the args are set, because checking their value would be False for 0 (all cores)
    @KernAttila
    KernAttila committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    02fac67 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'cuesubmit-jobs-from-config-file' of https://github.com/… 

    …Wolf-Pipeline/OpenCue into cuesubmit-jobs-from-config-file
    @KernAttila
    KernAttila committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    3b028b9 View commit details
    Browse the repository at this point in the history

  4. fix: cast str to float

    @KernAttila
    KernAttila committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    936f368 View commit details
    Browse the repository at this point in the history

  5. feat: add opencue icon to cuesubmit window

    @KernAttila
    KernAttila committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    73a66eb View commit details
    Browse the repository at this point in the history

  6. fix: add overrideCores attribute in LayerData.toDict()

    @KernAttila
    KernAttila committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    134fd5d View commit details
    Browse the repository at this point in the history

  7. test: add overrideCores param

    @KernAttila
    KernAttila committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    261db2f View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Merge branch 'master' into cuesubmit-jobs-from-config-file

    @KernAttila
    KernAttila authored Oct 18, 2024
    Configuration menu
    Copy the full SHA
    fda4ab8 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Merge branch 'master' into cuesubmit-jobs-from-config-file

    @KernAttila
    KernAttila authored Nov 8, 2024
    Configuration menu
    Copy the full SHA
    7e3b181 View commit details
    Browse the repository at this point in the history