Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rqd] Python tests for rqd only v2 #1548

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

lithorus
Copy link
Contributor

@lithorus lithorus commented Oct 18, 2024

Link the Issue(s) this Pull Request is related to.
Is loosely related to #1441

Summarize your change.
Introduces small tests for RQD only on pull requests that tests "vanilla" python version from 3.7 to 3.11.

This is to make sure that rqd and basic pycue works with as many versions of python and not just the ones used by VFX platform and perhaps even prepare support for cutting edge python versions.

It also introduces the requirements directory to include more split up dependencies.

Edit :
This is based on PR #1547
Have not added python 3.13 since it doesn't support 2to3 anymore. Will need another solution for that (perhaps a simple sed command?)

@DiegoTavares DiegoTavares marked this pull request as ready for review October 21, 2024 16:54
@DiegoTavares DiegoTavares marked this pull request as draft October 21, 2024 16:55
@DiegoTavares
Copy link
Collaborator

Sorry, I've accidentally marked this PR as ready.

@DiegoTavares
Copy link
Collaborator

I like where this PR is going.

There's one thing I've been wanting to change on the project for a long time related to how we declare dependencies on requirements.txt and the whole setup.py weirdness. Python now support project configuration using a toml file which seems to be easier to maintain and more readable.

I'm not proposing this should be tackled on this PR, but since it proposes a new directory for requirements, maybe it is a good time to investigate what it would take to convert the setup.py to toml.

There's a good guideline here:
https://medium.com/@devsjc/the-complete-guide-to-pyproject-toml-replace-setup-py-and-requirements-txt-553f899dc267

@lithorus
Copy link
Contributor Author

Very interesting. Looks much better than the directory structure and I really like the optional part. But this PR was a good exercise into splitting it up.

@lithorus lithorus marked this pull request as ready for review October 22, 2024 19:57
@DiegoTavares
Copy link
Collaborator

DiegoTavares commented Oct 25, 2024

Looking at the unit tests for rqd, I get the sense they are not really being executed.

It looks like both runLinux and runDarwin are failing but the ci job is still being marked as Success

@DiegoTavares
Copy link
Collaborator

It turns out unittest was not reporting test interruptions, so only part of our test were running.

Here's my PR fixing some of the tests and replacing unittest with pytest (WIP)
#1560

@lithorus lithorus marked this pull request as draft November 8, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants