-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Python wheels workflow and build backend #4428
Open
zachlewis
wants to merge
180
commits into
AcademySoftwareFoundation:main
Choose a base branch
from
zachlewis:python_cibuildwheels
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+842
−38
Open
Changes from all commits
Commits
Show all changes
180 commits
Select commit
Hold shift + click to select a range
d8e0955
build: Improve Python3 component detection
zachlewis df83fc8
Add pyproject.toml for building wheels with scikit-build-core
zachlewis 5e86b2d
int(python): Adjust module metadata
zachlewis ea2432a
build(deps): Improve ability to build, link, and alias shared and sta…
zachlewis 5c1a1b8
build(deps): Add libjpeg-turbo recipe
zachlewis 78fed97
refactor: Simplify structure of Python module
zachlewis bd271a3
docs: clarify that IBA::rotate params are pixel coordinates (#4358)
lgritz d298bad
build: A few cmake cleanups and minor code rearrangements (#4359)
lgritz f9d7f21
Revert libdeflate-related changes to externalpackages.cmake
zachlewis f555161
build(python): set RPATHs to relative paths to distribution's 'libs' …
zachlewis 5f70b0a
build(python): Improve pip-based build experience
zachlewis 3337f70
build(python): Force TIFF to always build locally only for CIBW
zachlewis 50f0b4e
cleanup: fix comment, whitespace
zachlewis 2013d09
build: pyproject housekeeping
zachlewis 7180872
build: slim down wheels w/ refactored CIBW repair-wheel-command step
zachlewis 1997724
build: add `rye` artifacts to gitignore
zachlewis 80acc8c
build: simplify wheel_edit task
zachlewis 2ee72cd
cleanup: add copyright and license information to tasks.py
zachlewis 0f5e1a3
build(deps): add zlib build recipe
zachlewis 13f60ce
build(deps): add yaml-cpp build recipe
zachlewis b96525e
build(python): On windows, include Development.Embed Python3 component
zachlewis 42caf75
build(python): Increase verbosity of scikit-build-core build
zachlewis 5a70d3e
build(wheels): Refine build process and Windows compatibility
zachlewis 151333f
cleanup(python): formatting for PEP compliance
zachlewis 0810544
ci: add wheel workflow
zachlewis bf4265e
fix(IB): copy/paste error in the ImageBuf iterator copy constructor (…
antond-weta 1c7cd37
feat(oiiotool): additional stack commands and --for improvement (#4348)
lgritz ea63dbb
int: Rename env OIIOTOOL_METADATA_HISTORY -> OPENIMAGEIO_METADATA_HIS…
lgritz 781ee80
feat(jpeg): output hint "jpeg:iptc" (#4346)
lgritz 6eddaf5
fix(png): round dpi resolution to nearest 0.1 (#4347)
lgritz 5ca303d
raw: expose additional white balancing hints (#4360)
antond-weta 3599081
api: move OIIO::pvt::error and log_time into the exposed OIIO namespa…
lgritz 2db7b90
admin: Relicense code under Apache 2.0 (#3905)
lgritz 2c10095
api: add pvt::heapsize() and pvt::footprint() methods and image cache…
bfraboni a7c8fd8
deps: Make OCIO 2.2+ a required dependency (#4367)
lgritz c4b6bb0
fix(oiiotool): `-i:ch=...` didn't fix up alpha and z channels (#4373)
lgritz 25df0aa
cleanup: Remove unused test output ref from old dependency versions (…
lgritz a1d809b
build: CI sanitizer test improvements (#4374)
lgritz 1f45b2f
build(deps): Raise libheif minimum to 1.11 (#4380)
lgritz becb6e8
fix(windows): fix for setenv() on Windows (#4381)
ssh4net 0eedbcb
build: Don't link libOpenImageIO against OpenCV (#4363)
lgritz ef615c8
api: use shared_ptr for ImageCache and TextureSystem (#4377)
lgritz 87d2e70
Bump version to indicate ABI changes
lgritz 3122823
ci: Bump ABI standard in master
lgritz ce0b5b8
cleanup: Fix typo where apostrophe was used for possessive of 'it' (#…
JGoldstone 660d068
style: Turn on clang-format for ivmain.cpp (#4382)
lgritz 9db71c5
int: Beef up some error messages (#4369)
lgritz bd12ec9
docs: typo fix (#4385)
lgritz 1a0adf6
fix: Catch potential OCIO exception that we were missing (#4379)
lgritz f27f092
ptex: Store full metadata only at subimage 0, miplevel 0 for ptex fil…
lgritz cad150d
fix(png): bug in associateAlpha botched alpha=0 pixels (#4386)
lgritz d8ad61f
feat(iba): IBA::demosaic() for bayer pattern demosaicing (#4366)
antond-weta 14f7bb0
build: Add proper detection of new FFmpeg versions (#4394)
darbyjohnston 066e571
docs: clarify TextureSystem::create use of imagecache when shared=tru…
lgritz 8289357
fix(iba): Add missing version of warp (#4390)
lgritz 087605a
feat(ffmpeg): FFmpeg additional metadata (#4396)
darbyjohnston 9e5d1e5
fix(iba): IBA::transpose() didn't set output image's format to input …
lgritz acb513a
dev: span utility improvements (#4398)
lgritz f784415
feat(raw): make the crop match in-camera JPEG (#4397)
antond-weta 22dfb86
api!: add virtual heapsize() and footprint() to ImageInput and ImageO…
bfraboni 1c3370e
refactor!: de-virtualize IC and TS (#4384)
lgritz 9818a04
feat: implement support for OCIO NamedTransforms (#4393)
zachlewis 6384b5d
fix: Don't let fmtlib exceptions crash the app (#4400)
lgritz 11e84e6
CHANGES and bump version to 2.6.5.0
lgritz e1fc73f
Update ABI reference commit / stage for developer preview v2.6.5.0
lgritz e19ab97
Bump version after developer preview tag
lgritz a8362ad
docs: Switch license name in docs (#4407)
lgritz be9027f
api: Fold span_util.h contents into span.h (#4402)
lgritz 1ddddd8
api(IB): Add span-based constuctors to ImageBuf (#4401)
lgritz f4f5ee8
ci: Bump the dependency versions for the 'latest' test to the actual …
lgritz 9e40cb0
ci: add a workflow that builds docs (#4413)
lgritz 36c5275
ci: adjust wheel cron and add workflow_dispatch
zachlewis 5397de1
ci: temporarily remove the push "tags" constraint for the wheel workflow
zachlewis 68c5497
ci(wheel): Updated deployment target for MacOS
zachlewis e3f07e1
fix(python): updated PYTHON_SITE_DIR setting for skbuild
zachlewis c18d241
fix(python): For macOS, ensure dependencies are built for the correct…
zachlewis d85dfc8
fix(ci): Move per-platform repair-wheel-cmd to correct parts of config
zachlewis d719823
ci(wheels): temporarily use "Release" instead of "MinSizeRel" bld type
zachlewis 0505040
docs: Convert more examples within the imagebufalgo chapter. (#4039)
buddly27 318e4ff
test: Fix tests that were writing into ref (#4418)
lgritz 4c91126
fix(deps): Turn off building shared libs for libdeflate; refind zlib
zachlewis 4ef5553
fix(deps): Don't try to refind a config for ZLIB
zachlewis edff8a6
docs: Add a few words about building with the python build-backend.
zachlewis 245c51e
cleanup: add and clarify pyproject.toml comments
zachlewis e52c3cf
ci: prepare Wheels workflow for PR
zachlewis 6d25552
ci(wheels): use "oiiotool --help" as a test command.
zachlewis 16793db
ci(wheels): Use new pypi "trusted publisher" workflow
zachlewis edda093
ci(wheels): Exclude unnecessary directories from the source distribution
zachlewis f465ba5
Merge branch 'master' into python_cibuildwheels
zachlewis d0adf3a
ci(wheels): Build macos arm64 wheels on macos arm64 runners
zachlewis d6872e5
deps: add build recipe for PNG
zachlewis 5904090
deps(PNG): always build static PNG
zachlewis 3cbb73d
deps(PNG): Always build with -fPIC
zachlewis 0fdace1
deps(PNG): Always build shared libs
zachlewis 0160971
deps(PNG): adjust libpng library install dir
zachlewis 35210f1
deps(PNG): disable Framework build for libpng
zachlewis 889e46d
ci(wheels): Use newer macos x86_64 runners, and refine publish condition
zachlewis f5e118d
deps(yaml-cpp): specify that yaml-cpp is a dependency of OCIO
zachlewis 16d634e
cleanup: Minor adjustments to pyproject.toml
zachlewis ce5db05
fix(wheels): disable free-threaded support for now
zachlewis ab7e348
ci(wheel): revert CIBW environment override
zachlewis ffa522e
deps(PNG): Always disable shared libs
zachlewis 1258db1
ci(wheels): Use macos-14 runners for linux arm builds; use latest cibw
zachlewis 5dc9ceb
ci(wheels): refine process for building Linux aarch64 wheels
zachlewis 2a5e713
ci(wheels): Install Docker to macos-14 runner for cross compile
zachlewis 59787c2
ci(wheels): Use podman instead of Docker for MacOS ARM64 Linux cross
zachlewis 72402d2
ci(wheels): Revert to using a linux runner for building aarch64 wheels
zachlewis c313ad3
Merge branch 'main' into python_cibuildwheels
zachlewis 36a4d29
deps: Remove yaml-cpp and PNG recipes
zachlewis f21a834
ci(wheels): Add CPython 3.13, and improve linux ARM builds
zachlewis 18d192f
Merge branch 'main' into python_cibuildwheels
zachlewis fb677f4
cleanup: reconcile minor differences with main branch
zachlewis 37fbfa3
ci(wheels): Use homebrew to install libpng on MacOS ARM runners
zachlewis 25a6ed7
fix(wheels): Temporarily disable PNG plugin for MacOS ARM64 runners
zachlewis e9e3197
ci(wheels): install python 3.8 to macos-14 runners
zachlewis d214039
Merge branch 'main' into python_cibuildwheels
zachlewis 77b7436
cleanup(wheels): make tasks.py a little prettier
zachlewis 25d774c
deps(libdeflate): revert changes to build recipe
zachlewis 7e9e687
Revert "deps(libdeflate): revert changes to build recipe"
zachlewis e45ca15
fix: test python-colorconfig with the same config for all OCIO vers
zachlewis 5f76706
build(pyproject): bump build-reqs: numpy-2
zachlewis c6c25a4
ci(wheels): remove unnecessary QEMU setup
zachlewis 3a3deee
fix: typo in pyproject build requires
zachlewis 1e05f5d
Revert "fix: test python-colorconfig with the same config for all OCI…
zachlewis e6f818b
fix: adjust numpy build requirement
zachlewis 5f4caf5
testing: temporarily disable numpy build requirement
zachlewis 6b2fb9f
ci(wheels): Disable py3.8 builds
zachlewis af99af9
fix: tiny update to .gitignore
zachlewis bf451a5
fix: Reenable Python-3 module when using cmake < 3.18
zachlewis b2a1e4d
ci(wheels): macos_x86: disable WebP, HEIF plugin, use macos-13 runner
zachlewis 31cc8f0
ci(wheels): macos-x86_64: revert to macos-12 runners
zachlewis 9f6aedf
deps(TIFF): turn off support for WebP compression
zachlewis 130a108
testing: Update test ref output for OpenColorIO 2.4 (#4459)
lgritz 3903ef2
fix(wheels): LINKSTATIC=1 to prefer built static libs over sys dylib
zachlewis a0af477
fix(wheels): macOS: build _all_ deps locally
zachlewis 35b4af6
ci(wheels): MacOS: brew uninstall freetype
zachlewis bfae087
ci(wheels): MacOS x86_64: reenable WebP
zachlewis 77fcc6b
Merge branch 'main' into python_cibuildwheels
zachlewis a615763
ci: Remove old MacOS-12 CI test
lgritz b13a055
Don't exclude MacOS 12, just disable OpenCV and Qt homebrew install f…
lgritz b4b1269
ci: Streamline the old MacOS-12 CI test (#4465)
lgritz 5bba64d
ci: Test against OpenEXR 3.3 and deal with its 4.0 bump
lgritz 7b37f05
ci:(wheels): macos-x86_64 - move "brew uninstall" cmd to workflow
zachlewis 6f61f63
cleanup: remove unnecessary stuff from pyproject.toml and wheel.yml
zachlewis d07cbe8
build: Raise CMake minimum to 3.18
lgritz 853952e
Fix prob with cmake 3.18.0..3.18.1
lgritz cf648f2
cleanup: assume cmake >= 3.18 when building python modules
zachlewis 221e4d8
cleanup: python __init__.py, warn about loading DLLs from PATH on Win
zachlewis 1036870
build: Raise CMake minimum to 3.18
lgritz a882bcf
Merge branch 'main' into python_cibuildwheels
zachlewis c5ded6f
Merge remote-tracking branch 'origin/python_cibuildwheels' into pytho…
zachlewis 63c7b56
Merge remote-tracking branch 'lgritz/lg-cmakedep' into python_cibuild…
zachlewis 1fba61d
cleanup(pyproject): Remove numpy dep + MacOS arch CMake defines
zachlewis f10ecfa
ci(wheels): brew-uninstall freetype for macos-arm64 runs
zachlewis 7a56416
ci(wheels): Adjust Workflow perms, GH pin Action vers, reenable cp38
zachlewis db440e9
Merge branch 'main' into python_cibuildwheels
zachlewis 978e8f0
Update docs URL in pyproject.toml
zachlewis d45e634
ci(wheels): Use CMAKE_IGNORE_PREFIX_PATH instead of uninstalling stuff
zachlewis deeba08
build: Add IGNORE_HOMEBREWED_DEPS CMake option
zachlewis 9fa0a76
ci(wheel): use macos-13 instead of 12 for macos-x86_64 builds
zachlewis 380e8c8
build: make sure IGNORE_HOMEBREWED_DEPS removes paths from system path
zachlewis 34d7e3a
build(wheels): Don't install versioned copies of libraries
zachlewis 494a53c
build(wheels): provide cmake prefix hint for downstream skbuild pkgs
zachlewis 9d0645d
build: add /opt/X11 to prefixes skipped by IGNORE_HOMEBREWED_DEPS
zachlewis d9b37c0
ci(wheels): disable CIBW repair-wheel step + remove tasks.py
zachlewis 110e69a
build: improve IGNORE_HOMEBREWED_DEPS building
zachlewis 5373e98
Revert "build(wheels): Don't install versioned copies of libraries"
zachlewis b13051d
Merge branch 'main' into python_cibuildwheels
zachlewis 82053dd
deps(OCIO): disable versioning in shared lib name when building
zachlewis 9437415
build: add "NAMELINK_SKIP" option to install_targets
zachlewis 3e60ade
build(wheels): adjust RPATHs and skip namelinks
zachlewis a3fd5ea
ci(wheel): re-enable default CIBW repairwheel step
zachlewis f63dbfb
Merge branch 'main' into python_cibuildwheels
zachlewis f98635f
python(__init__.py): Set $OpenImageIO_ROOT before importing the module
zachlewis 8fdc0d5
build(wheels): bump MACOSX_DEPLOYMENT_TARGET to 11
zachlewis 3524c4f
Merge branch 'main' into python_cibuildwheels
zachlewis babfa59
build(wheel): Only install Py module, libs, fonts, oiiotool and maketx
zachlewis 6d8ceb5
cleanup: Refactor DLL loading and remove metadata from __init__.py
zachlewis 2fed38e
cleanup(pyproject): remove CIBW stuff related to incremental building
zachlewis 678f530
cleanup: remove unused logger from python module's init.py
zachlewis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,122 @@ | ||
[project] | ||
name = "OpenImageIO" | ||
# The build backend ascertains the version from the CMakeLists.txt file. | ||
dynamic = ["version"] | ||
description = "Reading, writing, and processing images in a wide variety of file formats, using a format-agnostic API, aimed at VFX applications." | ||
authors = [ | ||
{name = "Larry Gritz", email = "[email protected]"}, | ||
{name = "OpenImageIO Contributors", email = "[email protected]"} | ||
] | ||
maintainers = [ | ||
{name = "OpenImageIO Contributors", email="[email protected]"}, | ||
] | ||
readme = "README.md" | ||
license = {text = "Apache-2.0"} | ||
classifiers = [ | ||
"Natural Language :: English", | ||
"Operating System :: OS Independent", | ||
"Programming Language :: Python :: 3", | ||
"Programming Language :: Python :: 3.8", | ||
"Programming Language :: Python :: 3.9", | ||
"Programming Language :: Python :: 3.10", | ||
"Programming Language :: Python :: 3.11", | ||
"Programming Language :: Python :: 3.12", | ||
"Programming Language :: Python :: 3.13", | ||
"License :: OSI Approved :: Apache Software License", | ||
"Topic :: Multimedia :: Graphics", | ||
"Topic :: Multimedia :: Video", | ||
"Topic :: Multimedia :: Video :: Display", | ||
"Topic :: Software Development :: Libraries :: Python Modules", | ||
] | ||
requires-python = ">= 3.8" | ||
|
||
[project.urls] | ||
Homepage = "https://openimageio.org/" | ||
Source = "https://github.com/AcademySoftwareFoundation/OpenImageIO" | ||
Documentation = "https://docs.openimageio.org" | ||
Issues = "https://github.com/AcademySoftwareFoundation/OpenImageIO/issues" | ||
|
||
|
||
[project.scripts] | ||
# Use the convention below to expose CLI tools as Python scripts. | ||
maketx = "OpenImageIO:_command_line" | ||
oiiotool = "OpenImageIO:_command_line" | ||
|
||
[build-system] | ||
build-backend = "scikit_build_core.build" | ||
requires = [ | ||
"scikit-build-core>=0.10.6,<1", | ||
"pybind11", | ||
] | ||
|
||
[tool.scikit-build] | ||
build.verbose = true | ||
# Exclude unnecessary directories from the source distribution. | ||
sdist.exclude = [".github", "testsuite", "ASWF", "docs"] | ||
# Pin minimum scikit-build-core to that specified in build-system.requires. | ||
minimum-version = "build-system.requires" | ||
# Pin minimum CMake version to that specified in CMakeLists.txt. | ||
cmake.version = "CMakeLists.txt" | ||
wheel.license-files = ["LICENSE.md", "THIRD-PARTY.md"] | ||
# Make sure the package is structured as expected. | ||
wheel.install-dir = "OpenImageIO" | ||
# Only install the user and fonts components. | ||
install.components = ["user", "fonts"] | ||
|
||
[tool.scikit-build.cmake.define] | ||
# Build missing dependencies. See src/cmake for details. | ||
OpenImageIO_BUILD_MISSING_DEPS = "all" | ||
# Don't build tests. Dramatically improves build time. | ||
OIIO_BUILD_TESTS = "0" | ||
# Prefer linking static dependencies when possible. | ||
LINKSTATIC = "1" | ||
# Standardize the install directory for libraries, as expected by | ||
# other parts of the wheels build process. | ||
CMAKE_INSTALL_LIBDIR = "lib" | ||
|
||
# Dynamically set the package version metadata by pasrsing CMakeLists.txt. | ||
[tool.scikit-build.metadata.version] | ||
provider = "scikit_build_core.metadata.regex" | ||
input = "CMakeLists.txt" | ||
regex = 'set \(OpenImageIO_VERSION "(?P<value>[0-9a-z.]+)"\)' | ||
|
||
# On macOS, ensure dependencies are only built for the target architecture. | ||
[[tool.scikit-build.overrides]] | ||
if.platform-system = "darwin" | ||
if.platform-machine = "arm64" | ||
inherit.cmake.define = "append" | ||
cmake.define.CMAKE_OSX_ARCHITECTURES = "arm64" | ||
|
||
[[tool.scikit-build.overrides]] | ||
if.platform-system = "darwin" | ||
if.platform-machine = "x86_64" | ||
inherit.cmake.define = "append" | ||
cmake.define.CMAKE_OSX_ARCHITECTURES = "x86_64" | ||
|
||
[tool.cibuildwheel] | ||
build-verbosity = 1 | ||
skip = [ | ||
# Skip 32-bit builds | ||
"*-win32", | ||
"*-manylinux_i686", | ||
# Building with musl seems to work, but the repair-wheel step seems to fail... | ||
# This may be a bug in repairwheel (or auditwheel)? | ||
"*musllinux*", | ||
] | ||
test-command = "oiiotool --buildinfo" | ||
|
||
[tool.cibuildwheel.macos.environment] | ||
SKBUILD_CMAKE_ARGS = "-DLINKSTATIC=1; -DIGNORE_HOMEBREWED_DEPS=1" | ||
# C++17 - std::filesystem is only available in macOS 10.15 and later; ARM compatibility introduced in 11. | ||
MACOSX_DEPLOYMENT_TARGET = "11" | ||
# Optimize for size (not speed). | ||
SKBUILD_CMAKE_BUILD_TYPE = "MinSizeRel" | ||
|
||
[tool.cibuildwheel.linux.environment] | ||
SKBUILD_CMAKE_ARGS = "-DLINKSTATIC=1" | ||
# Suppress warnings that cause linux cibuildwheel build to fail | ||
CXXFLAGS = "-Wno-error=stringop-overflow -Wno-pragmas" | ||
SKBUILD_CMAKE_BUILD_TYPE = "MinSizeRel" | ||
|
||
[tool.cibuildwheel.windows.environment] | ||
SKBUILD_CMAKE_BUILD_TYPE = "MinSizeRel" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is kind of reverting what was made before. You could pass
-DCMAKE_INSTALL_RPATH
on a per platform basis instead.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, before, I think CMAKE_INSTALL_RPATH was defaulting to an absolute path; whereas now, it uses loader-path-relative defaults. We could still pass the option on a per-platform basis, but I'm not sure how that would be advantageous...?