Add testminimal and a new testsuite case. #1832
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new testsuite case that seemed more convenient to add with a new test program instead of modifying testshade. However, if testshade can be easily modified to add this testsuite case then this PR might not be needed, however as is testshade doesn't even call "closure->as_comp()". Also, testrender doesn't support batched mode so that one can't be used for this testsuite case either without major modifications.
Additionally, OSL has no minimal sample and this PR adds one. I needed a minimal sample when I started using OSL.
Also, #1800 and #1801 need new testsuite cases that would be easy to add with testminimal but not necessarily so with testshade.
Tests
I added a new testsuite case "closure-string" that fails in AVX2 batched mode and also with non-batched icc/icx.
#1831 should fix the failed test cases so this would need to be accepted after that one.
Checklist:
already run clang-format v17 before submitting, I definitely will look at
the CI test that runs clang-format and fix anything that it highlights as
being nonconforming.