Replace the tab key with 4 spaces in olstoy editor #1875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Signed-off-by: Ryan Bottriell <[email protected]>
rydrman
force-pushed
the
osltoy-editor-tabs-as-spaces
branch
from
b266b55
to
7cc2a5e
Compare
|
Sounds like ILM is going to handle the dev days CLAs all together in the coming days, but I'm aware that it needs to be done here still |
lgritz
reviewed
Sep 28, 2024
Comment on lines
+77
to
+80
| auto replacement | ||
| = QKeyEvent(QEvent::KeyPress, Qt::Key_Space, | ||
| Qt::KeyboardModifiers(event->nativeModifiers()), | ||
| " "); |
There was a problem hiding this comment.
Hmmm, in most editors, does TAB do the equivalent of hitting SPACE 4 times? Or does it do the number of spaces to take you to the next 4-space boundary?
There was a problem hiding this comment.
Good point, I'm not sure why I didn't think of that. I'll take another look when I have a moment
There was a problem hiding this comment.
Ping just in case you're interested in fixing this up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the osltoy application to use 4 spaces in the editor window instead of tab characters.
Tests
I'm not sure that this change warrants a test case, but I did launch the application and ensure that the tab key does indeed insert 4 spaces into the exitor.
Checklist:
already run clang-format v17 before submitting, I definitely will look at
the CI test that runs clang-format and fix anything that it highlights as
being nonconforming.