Add hair_chiang_bsdf closure definition from MaterialX #1891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jstone-lucasfilm for vis. |
|
Related MaterialX issue for posterity: AcademySoftwareFoundation/MaterialX#1968 |
fpsunflower
force-pushed
the
chiang-hair-closure
branch
from
38cc005
to
81c9e06
Compare
lgritz
reviewed
Nov 13, 2024
src/shaders/stdosl.h
Outdated
| float azimuthal_roughness_TRT, | ||
| float cuticle_angle, | ||
| color absorption_coefficient | ||
| ); |
There was a problem hiding this comment.
Should this have a BUILTIN tag here like the others?
There was a problem hiding this comment.
Yes indeed. Updated.
Signed-off-by: Chris Kulla <[email protected]>
fpsunflower
force-pushed
the
chiang-hair-closure
branch
from
81c9e06
to
c238612
Compare
lgritz
merged commit 416410d
into
AcademySoftwareFoundation:main
21 of 23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This just adds a closure definition so the MaterialX project can work on their OSL backend bindings for this new BSDF.
Tests
We don't have an implementation of this closure (nor would be it be easy to provide since testrender doesn't support hair fibers and this model won't work well on triangulated hair. We'll have to rely on MaterialX and renderers implementing this closure for testing.
Checklist:
already run clang-format v17 before submitting, I definitely will look at
the CI test that runs clang-format and fix anything that it highlights as
being nonconforming.