Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testrender: Implement basic displacement shader support #1898

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fpsunflower
Copy link
Contributor

Description

Associate an (optional) displacement shader with each material. On startup, we execute the displacement for each face-vertex that has a valid displacement shader assigned.

Tests

Added a new test with a displaced sphere to show how this works.

Checklist:

  • I have read the contribution guidelines.
  • I have updated the documentation, if applicable.
  • I have ensured that the change is tested somewhere in the testsuite (adding new test cases if necessary).
  • My code follows the prevailing code style of this project. If I haven't
    already run clang-format v17 before submitting, I definitely will look at
    the CI test that runs clang-format and fix anything that it highlights as
    being nonconforming.

@fpsunflower
Copy link
Contributor Author

Looks like I need to grab updated reference images from the CI machine.

In any case, this PR should be reviewed after we get #1897 merged.

@lgritz
Copy link
Collaborator

lgritz commented Nov 13, 2024

Update: I've merged #1897 now, so you ought to be able to rebase on top of it in main.

Associate an (optional) displacement shader with each material. On startup, we execute the displacement for each face-vertex
that has a valid displacement shader assigned.

Signed-off-by: Chris Kulla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants