Set default shell on Windows to "powershell" #1578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanChristopheMorinPerso
force-pushed
the
change_default_shell_on_win
branch
from
73eb469
to
af1e9c4
Compare
JeanChristopheMorinPerso
force-pushed
the
change_default_shell_on_win
branch
from
af1e9c4
to
00e7ca1
Compare
|
LGTM. Thanks for the doc updates as well! |
|
Would probably need #1505 to prevent too many issues. |
JeanChristopheMorinPerso
force-pushed
the
change_default_shell_on_win
branch
from
00e7ca1
to
87e3d3a
Compare
JeanChristopheMorinPerso
force-pushed
the
change_default_shell_on_win
branch
from
87e3d3a
to
74d74da
Compare
Signed-off-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Jean-Christophe Morin <[email protected]>
JeanChristopheMorinPerso
force-pushed
the
change_default_shell_on_win
branch
from
74d74da
to
03e2ecf
Compare
|
I tested on Windows from a cmd shell: So it seems to be working as expected. It created a powershell (not pwsh) shell. |
JeanChristopheMorinPerso
merged commit c700e99
into
AcademySoftwareFoundation:main
55 checks passed
Pixel-Minions
pushed a commit
to Pixel-Minions/rez
that referenced
this pull request
Feb 14, 2024
…on#1578) Signed-off-by: Jean-Christophe Morin <[email protected]> Signed-off-by: Jose Enriquez <[email protected]>
PiloeGAO
added a commit
to PiloeGAO/rez
that referenced
this pull request
Sep 4, 2024
…Foundation#1578)" This reverts commit c700e99.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1559.
Set default shell on Windows to "powershell".
Note that I'm not 100% sure if this is really how it should be done. I couldn't find a better way.