Update type hint for the package_filter argument of ResolvedContext's constructor #1582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: brycegbrazen <[email protected]>
|
This makes sense to me, considering that the default type is a rez/src/rez/resolved_context.py Line 239 in a5977da |
JeanChristopheMorinPerso
approved these changes
Nov 12, 2023
JeanChristopheMorinPerso
merged commit 762a6c6
into
AcademySoftwareFoundation:main
28 checks passed
JeanChristopheMorinPerso
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1581
Updates type hint to be what is actually expected by ResolvedContext under the hood.
As noted by #1581, ResolvedContext expects a
PackageFilterListrather than aPackageFilterBasewhen deserializing from a dict, so this PR improves the documentation to match that.