Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Derive Debug for adapters #513

Merged
merged 3 commits into from
Feb 6, 2025
Merged

Conversation

drewcrawford
Copy link
Contributor

Derive the Debug trait for the unix platform adapter.

Side note, I now have code in the wings that relies on my PRs. I need to explore alternatives to relying on my patches landing here.

@DataTriny
Copy link
Member

Hello @drewcrawford, thank you for the patch.

Please apply the fixes from running cargo clippy and make sure to run cargo fmt. Your changes won't be accepted by our CI otherwise.

Would you mind doing the same for the Windows and macOS adapters? "No" is an acceptable answer.

@drewcrawford
Copy link
Contributor Author

Fixed and now with windows + macOS implementations

@DataTriny DataTriny changed the title [unix] Derive Debug for adapter fix: Derive Debug for adapters Feb 6, 2025
Copy link
Member

@DataTriny DataTriny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much.

@DataTriny DataTriny merged commit 753d904 into AccessKit:main Feb 6, 2025
9 checks passed
@github-actions github-actions bot mentioned this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants